Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance on Raspberry Pi (and maybe other Linux) #8801

Merged
merged 1 commit into from
Jun 4, 2016

Conversation

unknownbrackets
Copy link
Collaborator

Apparently, our mmap() was actually flushing to disk on Raspberry Pi.

Thanks go to @klyoungblood:
http://forums.ppsspp.org/showthread.php?tid=18879&pid=118445#pid118445

Didn't use shm_open, since it doesn't work on iOS and seemed like the more troublesome route. At least this way, nothing should get worse / fail to start. Note that /dev/shm is mostly a Linux thing.

It might be good for someone to validate that disk flushes aren't happening on other platforms, like iOS. We don't need to worry about Android or Windows, which don't use this code.

-[Unknown]

For some variants, /tmp will be tmpfs, but not always.  In case our mmap
fails to prevent flushing to disk (as apparently happens on Raspberry Pi),
shm will work better for us.

Thanks go to klyoungblood.
@hrydgard
Copy link
Owner

hrydgard commented Jun 4, 2016

Wow, that must have put some wear on those sd cards :)

@hrydgard hrydgard merged commit 6bbcf74 into hrydgard:master Jun 4, 2016
@unknownbrackets unknownbrackets deleted the tmpfs branch June 4, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants