Correct some scePsmf info retrieval funcs and error handling #8793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed #6401 |
This logic comes from Jpcsp. Let's report though and see if there's more.
These seem buggy, but generally sane.
And improve error handling in general.
|
Yes Widgets Odyssey has fixed |
|
Cool. Heh, so many scePsmfGetVideoInfo(). Should probably make that log using the debug level... -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tests - didn't have any sample data for PCM streams, so looked at Jpcsp for that. The way it currently handles channel ids and PCM seems sane and matches my samples so far, so borrowed that logic.
This handles stream type info better, returns more correct errors, and matches my tests on the data I have.
I'm hoping this will help #3338 potentially, and also specifically Widgets Odyssey, based on the log. If it does, we'll be down to only a GPS navigator and a game that probably has already been fixed in the "totally black screen" area of the forum.
Fixes #6401.
-[Unknown]