Core: Stop leaking file loaders #18244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes remote disc streaming caching getting invalidated constantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes remote disc streaming caching getting invalidated constantly.
I didn't really test the disc swap behavior. But some refactoring broke this so the pointer was just never remembered and therefore never freed. This caused the remote disc streaming cache to never get flushed, and also never unlock, so it always had to reload cache every time.
Had been wondering why remote disc streaming performance got so much worse but thought it was my my devices or something on my network, until I realized it was logging that the cache couldn't be locked.
-[Unknown]