Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend change from Win32 menu: Add quick workaround for instance counter misbehavior #18182

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

hrydgard
Copy link
Owner

Should really do this some better way.. but this is quick and safe for now.

See #18148

…nter misbehavior.

Should really do this some better way.

See #18148
@hrydgard hrydgard added this to the v1.16.3 milestone Sep 20, 2023
@hrydgard hrydgard merged commit dee84e6 into master Sep 20, 2023
18 checks passed
@hrydgard hrydgard deleted the change-backend-exit-fix branch September 20, 2023 17:32
@anr2me
Copy link
Collaborator

anr2me commented Sep 20, 2023

May be by sending WM_QUIT message using PostQuitMessage?

@unknownbrackets
Copy link
Collaborator

There are other problems too. On Linux, if PPSSPP crashes... you're pretty much (as a user) left with being unable to save settings in PPSSPP until you restart your computer.

Maybe as a fallback, each instance should write a timestamp periodically, and on startup it should count the number of timestamps that are more recent than 60 seconds ago or something. At least then the situation would self-resolve in edge cases. Still not perfect, though.

-[Unknown]

@hrydgard
Copy link
Owner Author

Hm. I haven't noticed behavior that bad on Linux, although I suppose most of my "crashes" while debugging end up as Ctrl+C, and then it's somehow not an issue? Either way, this seems worth to break out into a new issure report, so I'll do that.

@unknownbrackets
Copy link
Collaborator

It happened to me often enough on RISC-V testing that I temporarily hardcoded PPSSPP_ID = 1;... but I was crashing it pretty often in the beginning getting jit to work.

-[Unknown]

@hrydgard
Copy link
Owner Author

#18204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants