PPGe: Use texture windows for atlas text #18126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it software rendering, which correctly applies clamp/wrap limits at 512x512, still has readable text. Other textures may still be wrong.
|
I'm gonna merge this for 1.16.1 but thinking of adding a commit on top that only enables the windows when the soft gpu is on, just to minimize the change for most people - although this should be very low risk. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it software rendering, which correctly applies clamp/wrap limits at 512x512, still has readable text. Other textures may still be wrong.
Just a quick fix for #17885, not really optimal but should be fine. Also didn't really check any other texture drawing that might use the atlas.
-[Unknown]