Fragment "ubershader" option #17449
Merged
Fragment "ubershader" option #17449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
fragment-ubershader
branch
2 times, most recently
from
6966610
to
0aef258
Compare
hrydgard
force-pushed
the
fragment-ubershader
branch
from
0aef258
to
72cf531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When off, this almost claws back all the last remaining lost performance from 1.14 on low-end hardware (see #17439 )
When on, this keeps these two shader states (double flag and texalpha) dynamic, keeping the shader count low, and no noticable penalty on mid/high-range that I can see.
We'll set this automatically with some heuristics. Maybe make it configurable at some point.
I'm going to see if we can do without a bitfield to configure this, which makes it friendly towards older GPUs.
TODO in future PRs: