Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #16628 from hrydgard/remove-fog-fshader-flag" #17439

Merged
merged 1 commit into from
May 9, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented May 9, 2023

This reverts commit 10dee90, reversing changes made to 34c11c8.

Changes the fog back to be controlled by a fragment shader ID bit instead of by uniforms.

While this did reduce the shader count, I should have carefully benchmarked on older mobile GPUs - while not at all on newer GPUs, on ones like Mali-400, the hit is quite noticeable.

Same with the lmode flag, so I'm gonna have to revert that too. While risky just before a point release, these changes are fairly easy to see if they break..

Then for 1.16 I'll make a "fragment ubershader" flag, so we can choose between max fragment shader performance or minimizing the shader count for less stutter. Or maybe even compile specialized shaders in the background when using the ubershader..

@hrydgard hrydgard added GE emulation Backend-independent GPU issues Performance Unexpected slow performance issues labels May 9, 2023
@hrydgard hrydgard added this to the v1.15.4 milestone May 9, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented May 9, 2023

I'll do a little extra testing before merge btw.

Seems solid.

@hrydgard hrydgard merged commit 38c4c48 into master May 9, 2023
@hrydgard hrydgard deleted the revert-fog-fshader branch May 9, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues Performance Unexpected slow performance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant