Check for valid memory range when doing fast bone matrix loads #16697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reality, this is probably very rarely a real concern but we do get a measurable amount of crash reports here. Though if that first access crashes, which it seems to, we'd probably likely crash soon after this anyway...
unknownbrackets
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reality, this is probably very rarely a real concern but we do get a measurable amount of crash reports here. Though if that first access crashes, which it seems to, we'd probably likely crash soon after this anyway...
I think the performance hit here will be very small because the branches will be highly predictable.
See 16601