-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Android cleanup #16644
Additional Android cleanup #16644
Conversation
795185d
to
b7ffd7a
Compare
b7ffd7a
to
f3c08c4
Compare
f3c08c4
to
10c0b3f
Compare
@@ -650,7 +655,7 @@ extern "C" void Java_org_ppsspp_ppsspp_NativeApp_init | |||
EARLY_LOG("NativeApp.init() -- begin"); | |||
PROFILE_INIT(); | |||
|
|||
std::lock_guard<std::mutex> guard(renderLock); | |||
std::lock_guard<std::mutex> guard(renderLock); // Note: This is held for the rest of this function - intended? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only overlaps with shutdown and render, neither of which should start happening until init is done, IMHO. So it seems like a good thing for this lock to last the entire time.
That said, maybe we could run some more on the background or in a thread. I don't really think that would change this lock lifetime itself, but rather move other things out of this func directly.
-[Unknown]
No description provided.