Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Remove the new 0th descriptor set, move everything else back to desc set 0 #16599

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Dec 16, 2022

Reverting to see if this alone fixes #16588.

If it does, will keep it like this for the followup 1.14 releases and only reintroduce the extra descriptor set when we really need it.

I've also found a super cheap Redmi Note 4 with a cracked screen, so I'll be able to debug this properly and see if we should keep supporting Vulkan on these or not.

@hrydgard hrydgard added this to the v1.14.1 milestone Dec 16, 2022
@hrydgard hrydgard merged commit bd26250 into master Dec 16, 2022
@hrydgard hrydgard deleted the revert-to-single-descriptor-set branch December 16, 2022 12:35
hrydgard added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't enter the emulator's menu with vulkan render selected
1 participant