softgpu: Clamp/wrap textures at 512 pixels #15999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some math was overflowing in allocations, and it would allocate zero bytes. Let's just refuse textures more actively.
A texture larger than 512 is "valid", but simply wraps/clamps at 512. Importantly, the texture coords are still calculated at the specified size, which can be up to 32768.
unknownbrackets
force-pushed
the
softgpu-texsize
branch
from
1d66796
to
90e009e
Compare
|
I was thinking that we might want to do something for those PS3 remasters that do allow larger textures, but they already can't possibly work in the software renderer for a bunch of reasons, so, no :) |
|
Oh, hm, I'm not sure they can't possibly work? It's mostly doubled TCs which should work... I guess it's just display being higher. -[Unknown] |
|
Right, yeah, maybe they can run at PSP resolution. But since they were HLE emulated on the PS3, maybe they abuse PSP video memory in all kinds of interesting ways... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This almost passes hrydgard/pspautotests#222, but doesn't quite because the minification (512 or more texels to 256 pixels) in the test seems to be slightly off. Still, it fixes the >= 512 sized texture behavior which might have some interesting effects.
Luckily, it's fairly cheap to do so.
-[Unknown]