Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture dumping broken when texture upscaling is enabled #15488

Closed
hrydgard opened this issue Apr 17, 2022 · 4 comments
Closed

Texture dumping broken when texture upscaling is enabled #15488

hrydgard opened this issue Apr 17, 2022 · 4 comments
Labels
User Interface PPSSPP's own user interface / UX

Comments

@hrydgard
Copy link
Owner

As it says on the tin, the math goes wrong. Should be a pretty simple fix.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Apr 17, 2022
@hrydgard hrydgard added this to the v1.13.0 milestone Apr 17, 2022
@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Apr 17, 2022

Originally, it definitely did work, and it could be used to save upscaled textures to reduce CPU usage (i.e. to save the upscaled textures.) Maybe this is only when GPU upscaling is used? Or in all cases?

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Apr 17, 2022

tbh I only tested on top of #15487 , but did seem broken in both cases. Ran out of time to look into it today but will soon. Getting it to work with GPU upscaling might be too hard.

@unknownbrackets
Copy link
Collaborator

Right, there's already code to save the original size when using a shader for upscaling. Both paths seem to be working on Windows with Vulkan.

-[Unknown]

@hrydgard
Copy link
Owner Author

Gonna close this, doesn't seem to be an issue.

@hrydgard hrydgard removed this from the v1.13.0 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

No branches or pull requests

2 participants