Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu audio glitchfix #14101

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Menu audio glitchfix #14101

merged 2 commits into from
Feb 9, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Feb 9, 2021

Removes an unnecessary check that caused problems.

Also some assorted cleanup inspired by #14082 .

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Feb 9, 2021
@hrydgard hrydgard added this to the v1.11.1 milestone Feb 9, 2021
@hrydgard hrydgard merged commit 7095115 into master Feb 9, 2021
@hrydgard hrydgard deleted the menu-audio-glitchfix branch February 9, 2021 23:33
@unknownbrackets
Copy link
Collaborator

This was running often enough to need less than 16 samples? Not that I really disagree with it, but that seems more often than expected. That'd be at elast 2800 times per second / every 350 microseconds?

I guess the problem is, it'd push silence in that scenario.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants