Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D3D9] Screen shaking during FMV in all Hatsune Miku games #13374

Open
Leopard20 opened this issue Sep 3, 2020 · 11 comments
Open

[D3D9] Screen shaking during FMV in all Hatsune Miku games #13374

Leopard20 opened this issue Sep 3, 2020 · 11 comments
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@Leopard20
Copy link
Contributor

Leopard20 commented Sep 3, 2020

The screen shakes when playing the intro videos.
pd.zip
I'm not sure when this started happening, but I'm running the latest dev build (v1.10.3-550)

I'm not sure if this is related or not:
#13370

@hrydgard hrydgard added this to the v1.11.0 milestone Sep 3, 2020
@hrydgard
Copy link
Owner

hrydgard commented Sep 3, 2020

#13370 is likely related yes. The new framebuffer management that helped fix Test Drive needs a bit more work.

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Sep 3, 2020
@hrydgard
Copy link
Owner

Is this ok now after #13397 ?

@Leopard20
Copy link
Contributor Author

Leopard20 commented Sep 11, 2020

Nope. Not fixed yet.
Not sure if this is useful (it appears to be empty):
recording (3).zip

@hrydgard
Copy link
Owner

This only happens in D3D9, right?

@hrydgard hrydgard added the D3D9 Direct3D 9 label Oct 14, 2020
@hrydgard hrydgard modified the milestones: v1.11.0, v1.12.0 Oct 14, 2020
@Leopard20
Copy link
Contributor Author

I'm on Android! ¯_(ツ)_/¯
Vulkan and OpenGL

@hrydgard
Copy link
Owner

hrydgard commented Oct 15, 2020

Oh! Weird.

Using postprocessing effects?

@hrydgard hrydgard removed the D3D9 Direct3D 9 label Oct 15, 2020
@Leopard20
Copy link
Contributor Author

Leopard20 commented Oct 15, 2020

Good guess! Yeah. I removed the PP effects and it now looks fine.
I think both of "natural colors" effects have this issue. The rest looked fine.

I'll see if I can find the issue.

@hrydgard
Copy link
Owner

I'm guessing the game somehow ends up drawing the video in two different ways, one frame directly to the backbuffer and the other through a framebuffer, and it flips between those and there's a subtle offset bug in one of them when using postprocessing ...

@Leopard20
Copy link
Contributor Author

Leopard20 commented Oct 15, 2020

You were right about D3D9 though. It is broken with or without the shader. So please add the tag again.
I fixed the issue with one of the shaders. I'm not sure what the blurry one is doing tbh! :)

@Leopard20 Leopard20 changed the title Screen shaking during FMV in all Hatsune Miku games [D3D9] Screen shaking during FMV in all Hatsune Miku games Oct 16, 2020
@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Feb 21, 2021

I'm guessing the game somehow ends up drawing the video in two different ways, one frame directly to the backbuffer and the other through a framebuffer, and it flips between those and there's a subtle offset bug in one of them when using postprocessing ...

Yes, as per #3417. Maybe this is related to DrawFramebufferToOutput when it goes directly through presentation, i.e. not accounting for the half pixel offset?

-[Unknown]

@hrydgard
Copy link
Owner

Yes, that's what I'd guess.

@hrydgard hrydgard modified the milestones: v1.12.0, Future Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

3 participants