Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound effects for PPSSPP interface navigation #13239

Merged
merged 9 commits into from
Aug 3, 2020
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 2, 2020

Fixes #13225 .

Adds SELECT, BACK, CONFIRM, TOGGLE_ON and TOGGLE_OFF sound effects to the PPSSPP UI.

If anyone have better sounds, feel free to suggest replacements. Must not be under any license not compatible with PPSSPP's license.

  • Add an option
  • Replace the wave files
  • Find better places to hook up the sound effects to avoid double-triggering back/confirm

Still needs a lot of polish, but sets up the framework.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Aug 2, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Aug 2, 2020
@hrydgard
Copy link
Owner Author

hrydgard commented Aug 3, 2020

Turned it off by default since it needs more polish for that (and possibly shouldn't be on at all for mouse clicks, etc). But ready to start playing with.

@hrydgard hrydgard marked this pull request as ready for review August 3, 2020 10:15
@hrydgard hrydgard changed the title Draft: Add sound effects for PPSSPP interface navigation Add sound effects for PPSSPP interface navigation Aug 3, 2020
@hrydgard
Copy link
Owner Author

hrydgard commented Aug 3, 2020

Just gonna go ahead and merge this.

Remember, it's off by default so turn it on in System settings (or UIAudio in the .ini file) if you want to try it.

@hrydgard hrydgard merged commit ed946ed into master Aug 3, 2020
@hrydgard hrydgard deleted the interface-audio branch August 3, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add menu and interface sounds
1 participant