-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postprocessing: User chain support #12924
Conversation
Used configurable chain will need a cap to SSAA as stacking SSAA (Gauss) might get out of hand really quickly. |
Need to trigger RecreateViews to update the menu if the user change shader from the drop down menu while in the other menu, any better idea on how to handle it? |
8dd166c
to
f7a0933
Compare
Sorry for the delay on this, it'll need a rebase due to some minor conflicts, but should be easy to fix up. I've changed my mind a little bit, I like this enough now to merge this :) |
So it's already merged to the build yet or still need some more enhancement? Will be waiting for this update :) |
Not merged yet. @iota97 will need to update this a little bit. Or I can take care of it? |
I'll probabbly manage to take care of it this evening :) --Edit-- Ok, done. I'll put here a shader that can be used as last shader on the list to get a split preview like in @LunaMoo 's custom shader if someone need it:
|
Thanks, I'll take a quick look again a bit later before I merge. (The build error seems to be something temporary, so not an issue). |
Okay will wait for this. Thanks |
@Lemoncak3 if you want until this get merged and the build bot build the apk you can download this version from here. |
Sorry to ask again, just want to know when this is going to be implemented? Not urgent but want to try this feature because some of shader have it's own plus and minus. |
|
Caching the 60fps requirement as a hidden setting is maybe a little odd but okay for now. I'm gonna merge. |
Allow user to set up chain of effect:
TODO:
Handle Windows/Qt menu (just changed the name in the windows file without even testing, I will need to get a build environment for that too I guess).Shader that have require60fps, that check should be changed to check all the chain if at least one have it.