PPGe: Use TextDrawer for save UI if available #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
force-pushed
the
ppge-text
branch
3 times, most recently
from
d179989
to
af59473
Compare
We don't want to use just adler to cache strings. Also, port over the DPI handling to be consistent. Not tested.
We don't use these externally and probably won't.
This should result in better spacing for non-Latin characters, and less missing letters. Basically the same benefits as for the UI.
To match PPGE_LINE_USE_ELLIPSIS when using TextDrawer.
We need it to init on the correct thread.
unknownbrackets
force-pushed
the
ppge-text
branch
from
af59473
to
9c9ace6
Compare
|
Whoa, awesome work! There are some faint typical filtering-off-the-edge glitches as 2x+ resolution, but that should be pretty easy to fix by padding out by a pixel:
|
Prevents artifacts when the RAM previously had other data in it.
|
Good catch, the RAM was clear in most of the games I tried so didn't catch that. Did also catch an issue where \r was being doubled up (if passed already by the game.) -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, Windows, and Qt, this renders text for PPGe (in game save dialogs, message dialogs, etc.) with system fonts.
The benefit of this is that it should handle various languages, combining characters, etc. better. And just like with the UI, it won't have problems with missing characters either.
This also updates Qt's TextDrawer to cache the proper way, but I haven't tested Qt.
Fixes #10621, fixes #1904, fixes #1650, fixes #2127, and fixes #10879 (I think, the spacing looks better anyway.) It doesn't fix these on SDL, but we have #6681 for that already.
Also slipped in a small fix for decimating PPGe images.
-[Unknown]