EGL: Avoid HDR mode. Uses unknownbrackets' changes from #11839. #11845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +125,11 @@ EGLConfig EGL_FindConfig(int *contextVersion) { | |||
| EGLint caveat = readConfig(EGL_CONFIG_CAVEAT); | |||
| int caveatScore = caveat == EGL_NONE ? 100 : (caveat == EGL_NON_CONFORMANT_CONFIG ? 50 : 0); | |||
|
|
|||
| #ifndef USING_FBDEV | |||
| EGLint surfaceType = readConfig(EGL_SURFACE_TYPE); | |||
| int surfaceScore = (surfaceType & EGL_WINDOW_BIT) ? 100 : (caveat == EGL_NON_CONFORMANT_CONFIG ? 50 : 0); | |||
There was a problem hiding this comment.
Hmm, wait, this might accidentally boost non-conformant configs? Copy/paste mistake (possibly mine)?
-[Unknown]
There was a problem hiding this comment.
Yeah I just took it verbatim from your post :) You're right that this might not be great..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11839 .