Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle leak on Windows #11841

Closed
hrydgard opened this issue Feb 25, 2019 · 3 comments · Fixed by #11842
Closed

Handle leak on Windows #11841

hrydgard opened this issue Feb 25, 2019 · 3 comments · Fixed by #11842

Comments

@hrydgard
Copy link
Owner

hrydgard commented Feb 25, 2019

Looking at PPSSPP in Process Explorer, there's a strange issue where handles to games appears as open files unexpectedly. It repros the easiest by just rightclicking on a game in the menu.

Really not sure where these are coming from, but they have the annoying side effect that you can't fully delete a homebrew game that you just played, and it's never good to leak handles so this needs to be fixed.

Possibly Windows-specific.

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 25, 2019

Seems we're somehow leaking LocalFileLoader objects. It feels like it has something to do with CleanRecent but not sure. Either way it's kind of awkward that CleanRecent will try to do ConstructFileLoader on directories of homebrew, which tries to open them as files, which does work (since CreateFile failes, and then a directory check works) but it's odd.

@unknownbrackets
Copy link
Collaborator

This might be what #11698 was getting at.

-[Unknown]

@hrydgard
Copy link
Owner Author

Huh, indeed. Anyway, caught it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants