Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naruto Shippuden Ultimate Ninja 3: Probably a better fix for the video hang issue. #11780

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Feb 9, 2019

Fixes #9591, replaces #11772

Needs testing with other games!

@hrydgard hrydgard added the PSMF / MPEG Issue involves scePsmf or sceMpeg video playback. label Feb 9, 2019
@hrydgard hrydgard added this to the v1.8.0 milestone Feb 9, 2019
Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test this on more games indeed, but seems right to me.

I'll note that the warnings do occur at various times in games normally.

-[Unknown]

@@ -1694,7 +1695,11 @@ static int sceMpegGetAtracAu(u32 mpeg, u32 streamId, u32 auAddr, u32 attrAddr)
Memory::Write_U32(0, attrAddr);
}

DEBUG_LOG(ME, "%x=sceMpegGetAtracAu(%08x, %08x, %08x, %08x)", result, mpeg, streamId, auAddr, attrAddr);
if (result == 0) {
DEBUG_LOG(ME, "%x=sceMpegGetAtracAu(%08x, %08x, %08x, %08x)", result, mpeg, streamId, auAddr, attrAddr);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to change this to hleLogSuccessI / hleLogWarning while changing it...

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're doing a hleDelayResult below, I'm gonna leave it as is for now. I'm switching back to DEBUG.

@hrydgard
Copy link
Owner Author

I've tested this with a bunch of games that use video, have not noticed any problems. Let's try it.

@hrydgard hrydgard merged commit ccfcbc7 into master Feb 10, 2019
@hrydgard hrydgard deleted the naruto-video-fix branch February 10, 2019 10:45
@ghost
Copy link

ghost commented Feb 10, 2019

I will test if NSUNH3 is really fixed ty 😊

@ghost
Copy link

ghost commented Feb 10, 2019

So it's just the same using the cheat code skip intro movie 😐

The intro video is gone 🤔

@hrydgard
Copy link
Owner Author

This certainly didn't intend to skip a video. If there's a video missing, that's another bug...

@ghost
Copy link

ghost commented Feb 10, 2019

Here's the video
https://youtu.be/JeYJgZq3BRk

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 10, 2019

Do you have a video where it shows the missing video (maybe from a real PSP)?

I found this, and it doesn't have any extra video... https://www.youtube.com/watch?v=bRj0m2zE2SM

@ghost
Copy link

ghost commented Feb 10, 2019

Yeah you're right I thought a long movie intro I tested v1.3.0.1 they are the same introduction in ppsspp-v1.7.5-438-gccfcbc746 buildbot 😅

So finally the issue solved thanks for your hard work sir to fixed a long issue for this Naruto game in ppsspp

@hrydgard God bless you and thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PSMF / MPEG Issue involves scePsmf or sceMpeg video playback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants