-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] In-app build version and package manifest don't match #10837
Comments
Seems like some artifact of how the buildbot checks out the repo, what do you think @Orphis ? |
In game version name uses
|
That's weird, maybe it's ignoring certain commits in its counting? The code looks like it should skip that without onlyIn, though. Ultimately, we want the build version to be the same across all platforms, so I'd assert that androidGitVersion is the one that is "wrong" here. -[Unknown] |
I'm thinking about the commits made before tag, but merged after tag. |
I'm pushing this one forward, not critical enough (but definitely annoying!) |
Not a big issue, but I don't know why the in-app build version doesn't match the actual version of the package.
For example, build 804 version in AndroidManifest.xml is 1.5.4-790 instead of 1.5.4-804.
But the in-app reported version is 1.5.4-804.
It's a bit confusing to some people, don't you think?
The text was updated successfully, but these errors were encountered: