From 7dcd708fac1167e6e2038b91e54d8141990264b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= <hrydgard@gmail.com>
Date: Sat, 4 Jul 2020 23:45:03 +0200
Subject: [PATCH] Address some feedback

---
 Core/Core.cpp         | 2 +-
 Core/Core.h           | 1 +
 Core/MIPS/MIPSInt.cpp | 1 +
 Core/System.cpp       | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Core/Core.cpp b/Core/Core.cpp
index e3c8273f9e68..cf851e807e33 100644
--- a/Core/Core.cpp
+++ b/Core/Core.cpp
@@ -45,7 +45,6 @@
 #include "Windows/InputDevice.h"
 #endif
 
-
 // Time until we stop considering the core active without user input.
 // Should this be configurable?  2 hours currently.
 static const double ACTIVITY_IDLE_TIMEOUT = 2.0 * 3600.0;
@@ -385,6 +384,7 @@ const char *ExceptionTypeAsString(ExceptionType type) {
 	switch (type) {
 	case ExceptionType::MEMORY: return "Invalid Memory Access";
 	case ExceptionType::BREAK: return "Break";
+	case ExceptionType::BAD_EXEC_ADDR: return "Bad Execution Address";
 	default: return "N/A";
 	}
 }
diff --git a/Core/Core.h b/Core/Core.h
index 6f210c739b89..ef428595bd94 100644
--- a/Core/Core.h
+++ b/Core/Core.h
@@ -93,6 +93,7 @@ enum class ExceptionType {
 	NONE,
 	MEMORY,
 	BREAK,
+	BAD_EXEC_ADDR,
 };
 
 struct ExceptionInfo {
diff --git a/Core/MIPS/MIPSInt.cpp b/Core/MIPS/MIPSInt.cpp
index 9ca3ee67b16e..b8d99c078d69 100644
--- a/Core/MIPS/MIPSInt.cpp
+++ b/Core/MIPS/MIPSInt.cpp
@@ -151,6 +151,7 @@ namespace MIPSInt
 
 	void Int_Break(MIPSOpcode op)
 	{
+		Reporting::ReportMessage("BREAK instruction hit");
 		Core_Break();
 		PC += 4;
 	}
diff --git a/Core/System.cpp b/Core/System.cpp
index 9a6fcb1779ce..c8a8b4c769d0 100644
--- a/Core/System.cpp
+++ b/Core/System.cpp
@@ -97,7 +97,7 @@ bool coreCollectDebugStatsForced = false;
 
 // This can be read and written from ANYWHERE.
 volatile CoreState coreState = CORE_STEPPING;
-// Note: intentionally not used for CORE_NEXTFRAME. << TODO: This comment is a lie, it is used!
+// If true, core state has been changed, but JIT has probably not noticed yet.
 volatile bool coreStatePending = false;
 
 static volatile CPUThreadState cpuThreadState = CPU_THREAD_NOT_RUNNING;