Skip to content

Commit

Permalink
Use the double precision sincos for Hitman RBA 1 too. See #13706
Browse files Browse the repository at this point in the history
  • Loading branch information
@hrydgard
hrydgard committed Dec 5, 2020
1 parent fbeccc5 commit 2399c5f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions assets/compat.ini
View file
Original file line number Diff line number Diff line change
Expand Up @@ -826,3 +826,5 @@ ULKS46087 = true
[DoublePrecisionSinCos]
# Hitman Reborn Battle Arena 2 (#12900)
ULJS00218 = true
# Hitman Reborn Battle Arena
ULJS00157 = true

5 comments on commit 2399c5f

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented on 2399c5f Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason that not apply in all games ?

@hrydgard
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sum2012 the reasons are #13705 and #13671

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented on 2399c5f Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry,I mean apply special angle and apply double precision

@hrydgard
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that the double precision thing would eliminate the need to do special angles.

Maybe a combination could also fix it, but I think a better way is to write our own sin and cos functions and carefully try to match important cases with the real hardware. That will take a lot of work and research though....

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented on 2399c5f Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let my build to test whether cpu emulation problem belong to special angle nor double precision

Please sign in to comment.