Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Announcement: nvim-compe is now deprecated. #517

Closed
hrsh7th opened this issue Aug 9, 2021 · 11 comments
Closed

Announcement: nvim-compe is now deprecated. #517

hrsh7th opened this issue Aug 9, 2021 · 11 comments
Labels
wontfix This will not be worked on

Comments

@hrsh7th
Copy link
Owner

hrsh7th commented Aug 9, 2021

I'm developing new completion plugin to solve some of the design mistakes (the mistakes was described in here.

Currently, the new plugin can use as testing. (But I will apply breaking change without any announcement).

If someone interest it, please feel free to use it and report the issue to the new repo.

https://github.com/hrsh7th/nvim-cmp

@hrsh7th hrsh7th changed the title RFC: please test new version. RFC: Please test and feedback with new version. Aug 9, 2021
@Shougo
Copy link

Shougo commented Aug 10, 2021

I think this issue should be pinned.

@hrsh7th hrsh7th pinned this issue Aug 10, 2021
@hrsh7th
Copy link
Owner Author

hrsh7th commented Aug 10, 2021

Thank you! I did it.

@Iron-E
Copy link
Contributor

Iron-E commented Aug 11, 2021

As someone who uses this plugin myself and recommends it to others, I've always found it to be highly dependable. I'm not necessarily big on the idea of deprecating the entire plugin if instead certain features could be deprecated instead (like, for example, the VimL configuration which you mentioned).

If that's not possible, what I have noticed about cmp was that I think setting Neovim options through a plugin's setup function seems unnecessary. It could just be vim.opt.completeopt = {'menu', 'menuone', 'noselect'} on the line above cmp.setup {} in the README.

@hrsh7th
Copy link
Owner Author

hrsh7th commented Aug 12, 2021

No. The completeopt option is controlled by nvim-cmp. So it should be configuration option, I think.
The option is overwrote and restore by nvim-cmp itself. https://github.com/hrsh7th/nvim-cmp/blob/main/lua/cmp/menu.lua#L166

@Iron-E
Copy link
Contributor

Iron-E commented Aug 12, 2021

That's what I mean, I should have been more specific. I'm not sure cmp should automatically overwrite settings— in the past plugins have done that to my settings and it can be a little dubious finding out which is the culprit 😅

Perhaps an error would be good, if the settings aren't at least what cmp expects? That way users know and make the change themselves.

@hrsh7th
Copy link
Owner Author

hrsh7th commented Aug 12, 2021

In general, completion plugin manages completeopt setting... So I think it is not a strange way.

@Iron-E
Copy link
Contributor

Iron-E commented Aug 12, 2021

completion-nvim doesn't, compe issues a warning rather than overriding, and coc.nvim doesn't either.

All the "major" completion plugins don't touch user settings and either issue warning or simply have a note in the README.

I defer to you on these matters though, you have more experience writing these plugins

@Shougo
Copy link

Shougo commented Aug 13, 2021

Hm. completion-nvim does not change completeopt.
But it is not the perfect solution. Please read the issue.

nvim-lua/completion-nvim#235

The auto completion breaks longest behavior.

@hrsh7th hrsh7th changed the title RFC: Please test and feedback with new version. Announcement: nvim-compe is now deprecated. Aug 24, 2021
@stale
Copy link

stale bot commented Oct 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 23, 2021
@Shougo
Copy link

Shougo commented Oct 23, 2021

I think the issue should not be closed.

@stale stale bot removed the wontfix This will not be worked on label Oct 23, 2021
@stale
Copy link

stale bot commented Dec 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 23, 2021
@stale stale bot closed this as completed Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants