Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

No definition/description during autocomplete with the Deno LSP #187

Closed
David-Else opened this issue Feb 16, 2021 · 6 comments
Closed

No definition/description during autocomplete with the Deno LSP #187

David-Else opened this issue Feb 16, 2021 · 6 comments

Comments

@David-Else
Copy link

David-Else commented Feb 16, 2021

The tsserver lsp (https://github.com/neovim/nvim-lspconfig/blob/master/CONFIG.md#tsserver) shows a definition of the function during autocomplete:

tsserver-definition-in-autocomplete

but the denols lsp (https://github.com/neovim/nvim-lspconfig/blob/master/CONFIG.md#denols) does not:

denols-fetch-no-definition-in-autocomplete

but the definition is there as it is shown when K (lua vim.lsp.buf.hover()) is pressed:

denols-fetch-definition

Is this a problem with nvim-compe or the denols? Thanks.

NVIM v0.5.0-dev+1089-gdc3ca16a9 (updated today to latest version)
nvim-compe (updated today to latest version)

@elianiva
Copy link
Contributor

denols doesn't provide documentation for the completion item so nvim-compe can't display it. Here's what tsserver gave to nvim-compe

{
  commitCharacters = { ".", ",", "(" },
  data = {
    entryNames = { "fetch" },
    file = "/home/elianiva/codes/scratch/caesar.ts",
    line = 27,
    offset = 3
  },
  detail = "function fetch(input: RequestInfo, init?: RequestInit): Promise<Response>",
  insertTextFormat = 2,
  kind = 3,
  label = "fetch",
  sortText = "5"
}

compared to what denols gave

{
  insertTextFormat = 2,
  kind = 3,
  label = "fetch",
  sortText = "5"
}

Pretty sure it's in denols's todo list, we'll have to wait, I guess.

@hrsh7th
Copy link
Owner

hrsh7th commented Feb 17, 2021

@elianiva Thank you for your work. I'm very saved to your work around issue responsing.

@stale
Copy link

stale bot commented Apr 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 24, 2021
@David-Else
Copy link
Author

Good news, it now works with the latest version of Deno. Bad news, the formatting of the text looks bad, big empty grey area at the top.

Screenshot from 2021-04-24 09-45-31

@stale stale bot removed the wontfix This will not be worked on label Apr 24, 2021
@hrsh7th
Copy link
Owner

hrsh7th commented Apr 24, 2021

Hm... OK. I will check it. Thank you.

@David-Else
Copy link
Author

There is a new issue for the bad formatting #373

The issue with no definition/description during autocomplete with the Deno LSP seems solved so I will close the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants