fix: Error on using select_next_entry and select_prev_entry #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because get_selected_index check self.active before returning the index, which is false when select_next_entry is first called
|
Sorry, might be totally out of place adding this here, but: This fixes next and prev, but for some reason my autocomplete prompt is not by default selecting the first item in the list, to get to it I need to select_next then select_prev, any idea why? |
|
@samuelpx link to your prompt? Or maybe post it here? |
|
It is the same fix? |
|
Fixed by #1993, this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1988
get_selected_index was checking self.active before returning an index, which is actually false when select_next_entry is first called in typical usage using a mapping. Switched to how cursor was calculated before this PR #1986