Skip to content

Commit

Permalink
pythonGH-102973: Slim down Fedora packages in the dev container
Browse files Browse the repository at this point in the history
dnf install /usr/bin/... and dnf-command(builddep) to get exactly what we use.
That way, we abstract away (possibly artificial) package names.

This also fetches a slimmer version of git, called git-core,
which avoids a dependency on Perl.
However, Perl is eventually unfortunately still fetched in the next dnf command.

This declares more used dependencies in the spirit of
"explicit is better than implicit".

Also set install_weak_deps=False to avoid installing unneeded weak dependencies.
  • Loading branch information
hroncok committed Apr 5, 2023
1 parent 96e1901 commit ccd3b32
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ ENV WASMTIME_HOME=/opt/wasmtime
ENV WASMTIME_VERSION=7.0.0
ENV WASMTIME_CPU_ARCH=x86_64

RUN dnf -y --nodocs install git clang xz python3-blurb dnf-plugins-core && \
dnf -y --nodocs builddep python3 && \
RUN dnf -y --nodocs --setopt=install_weak_deps=False install /usr/bin/{blurb,clang,curl,git,ln,tar,xz} 'dnf-command(builddep)' && \
dnf -y --nodocs --setopt=install_weak_deps=False builddep python3 && \
dnf -y clean all

RUN mkdir ${WASI_SDK_PATH} && \
Expand Down

0 comments on commit ccd3b32

Please sign in to comment.