Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinitely plays current track (suspend related?) #34

Closed
medwards opened this issue Mar 15, 2019 · 11 comments
Closed

Infinitely plays current track (suspend related?) #34

medwards opened this issue Mar 15, 2019 · 11 comments
Labels
bug Something isn't working

Comments

@medwards
Copy link
Contributor

When coming back from suspend where a song was previously paused, I've noted that the song will play properly and un-pausing it, however when the song finishes the timer will just continue (ie 11:22 / 3:04) silently and not play the next song. It will honour pausing (so it will stop increasing if you "pause") when in this state.

Selecting other songs in the queue will result in the playback indicator updating, but no song will play. Restarting ncspot fixes this behaviour, but obviously resets the queue. I don't see anything notable in the log screen before restarting.

@medwards
Copy link
Contributor Author

I watched it more closely this time: Definitely something on suspend triggers it. The track does progress, but then the next track plays silently (possibly infinitely, didn't test this)

@hrkfdn hrkfdn added the bug Something isn't working label Mar 15, 2019
@hrkfdn
Copy link
Owner

hrkfdn commented Mar 15, 2019

Is this with your machine suspend for longer periods of time? Or did you test with a small suspend interval? I'm trying to rule out expired Spotify authentication tokens.

@medwards
Copy link
Contributor Author

medwards commented Mar 16, 2019 via email

@medwards
Copy link
Contributor Author

Unsuspended my work laptop after being away this weekend. ncspot successfully finished playing the track that had been paused before suspend, then the next track was silent.

If you make a patch with more logging for the conditions that you suspect are the root cause, I'll be happy to apply it and report back.

@hrkfdn
Copy link
Owner

hrkfdn commented Mar 18, 2019

Thanks for assisting. I have encountered this myself, but didn't have the time to take a closer look, yet.

You can enable librespot logging like so:
RUST_LOG="ncspot=trace,librespot=trace" cargo run 2>> stderr.log

This requires a commit I just pushed.

It could be the playback backend dying or the authentication token expiring. Maybe the logs give us something conclusive.

@medwards
Copy link
Contributor Author

Hmm, tried this an a few other variations bug I get no log output.

@hrkfdn
Copy link
Owner

hrkfdn commented Mar 19, 2019

Mhh. I have pushed something else that will just print everything in the debug view. Maybe that'll help?

@medwards
Copy link
Contributor Author

Some relevant output in the logs:
https://pastebin.com/xTyB9CYY

@hrkfdn
Copy link
Owner

hrkfdn commented Mar 23, 2019

Thanks for the report. Unfortunately, I can't really pinpoint the exact source of the problem. I'm guessing the session or audio backend is expiring.

I have added a "-d" commandline switch where you can supply a filename, to which it will log. The logs should be more verbose now, as all crates are included. If you still feel like it, maybe it'll yield something a little more conclusive.

@hrkfdn
Copy link
Owner

hrkfdn commented Mar 29, 2019

This is quite possibly related to that: librespot-org/librespot#134

@hrkfdn
Copy link
Owner

hrkfdn commented Jun 15, 2020

Duplicate of #192

@hrkfdn hrkfdn marked this as a duplicate of #192 Jun 15, 2020
@hrkfdn hrkfdn closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants