Windows linker error on nightly Rust (unresolved external symbol __imp_ExtractIconW referenced in function get_app_icon)

[udoprog]

Hey,

It seems like rust std will no longer link to shell32.dll, which is a dependency of pancurses (used through cursive for Windows support).

  = note: libpdcurses-b041d7947661b96d.rlib(pdcscrn.o) : error LNK2019: unresolved external symbol __imp_ExtractIconW referenced in function get_app_icon
          E:\work\repo\ncspot\target\debug\deps\ncspot-545a65ef205f4774.exe : fatal error LNK1120: 1 unresolved externals

Cursive and pancurses will need to be bumped once it has been fixed here:
ihalila/pdcurses-sys#5

A temporary workaround is to add a build.rs in ncspot with the following in it for Windows users:

fn main() {
    println!("cargo:rustc-link-lib=dylib=shell32");
}

[udoprog]

Related: rust-lang/rust#56568

[gyscos]

Should be fixed if you run cargo update

[hrkfdn]

@udoprog can you confirm it is fixed?

[udoprog]

I think so, but I can't test right now due to #38

[hrkfdn]

@udoprog I have switched to directories, wanna give it another spin? :)

[udoprog]

Yeah, fixed. Thanks!

[hrkfdn]

Great, thanks for reporting!