Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to install requirements-all.txt on Python 3.10 #145

Open
bhaddow opened this issue Jan 12, 2024 · 7 comments
Open

Fails to install requirements-all.txt on Python 3.10 #145

bhaddow opened this issue Jan 12, 2024 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bhaddow
Copy link
Contributor

bhaddow commented Jan 12, 2024

Installation fails on Python 3.10 fails because the specified version of OpusFilter (2.6.0) requires fast-mosestokenizer, and there is no version for 3.10.

I do not know if a later version of OpusFilter would be compatible.

@jindrahelcl
Copy link
Collaborator

FYI I use it with Python 3.8 for now, that's one version which doesn't seem to break anything

@bhaddow
Copy link
Contributor Author

bhaddow commented Jan 12, 2024

This also fails for me, because it tries to install bicleaner 0.17.3, which requests a broken hunspell.

@bhaddow
Copy link
Contributor Author

bhaddow commented Jan 12, 2024

If I comment out laserembeddings then it succeeds, and this appears to be just for ja and zh, so it's fine for me.

@jindrahelcl
Copy link
Collaborator

oh, you're right, I remember.. I only have bicleaner-hardrules in this env.

@jelmervdl
Copy link
Collaborator

jelmervdl commented Jan 12, 2024

It would be so easy to add a Github action to test the installation of requirements-all.txt on a couple of different platforms and python versions. It would probably be a lot harder to make them all work 😅

OpusFilter was indeed the one that dragged a hard to compile fast-mosestokenizer into the dependency tree. They've released a version 3.0.0 now: https://pypi.org/project/opusfilter/#history

… and I hope that they now rely on their fork of fast-mosestokenizer that does have wheels for Python 3.10 and newer: https://pypi.org/project/opus-fast-mosestokenizer/0.0.8.5/#files

There are quite a few commits between 2.6.0 and 3.0.0, not sure if there are any breaking changes. But by the looks of it, it might just work?

Upgrading OpusFilter and seeing whether that fixes it would be the first thing to try.

@jelmervdl jelmervdl added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 12, 2024
@mbanon
Copy link

mbanon commented Apr 19, 2024

I'm also having this issue >_<

@mbanon
Copy link

mbanon commented May 6, 2024

I'm also having this issue >_<

Hi, I fixed the versions issues in my fork and now everything seem to be installed and all filters working. In case anyone is interested:
dec5f6d
It also required a couple of minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants