From e4eb2689402169f02ec01f6398060446a681ed90 Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Fri, 18 Jun 2021 14:33:58 +0300 Subject: [PATCH 1/5] starting exception handling again --- .../instance/errorDictionary.st | 4 ---- .../instance/requestOn..st | 2 +- .../methodProperties.json | 4 +--- .../instance/errorDictionary.st | 7 ++++++ .../throwExceptionForResponseCode..st | 2 +- .../methodProperties.json | 2 ++ .../instance/errorDictionary.st | 4 ---- .../instance/requestOn..st | 2 +- .../throwExceptionForResponseCode..st | 4 ---- .../methodProperties.json | 4 +--- .../instance/validate..st | 2 +- .../methodProperties.json | 2 +- .../ATDDAccessDeniedError.class/README.md | 0 .../class/message.st} | 2 +- .../instance/defaultAction.st | 4 ++++ .../methodProperties.json | 5 +++++ .../properties.json | 4 ++-- .../ATDDConnectionError.class/README.md | 0 .../instance/defaultAction.st | 0 .../methodProperties.json | 5 +++++ .../properties.json | 4 ++-- .../README.md | 0 .../class/noValidSlugMessage.st | 0 .../instance/defaultAction.st | 0 .../methodProperties.json | 0 .../properties.json | 2 +- .../ATDDNotFoundError.class/README.md | 0 .../ATDDNotFoundError.class/class/message.st | 4 ++++ .../instance/defaultAction.st | 4 ++++ .../methodProperties.json | 5 +++++ .../properties.json | 4 ++-- .../GHAAccessDeniedError.class/README.md | 1 - .../instance/defaultAction.st | 4 ---- .../methodProperties.json | 5 ----- .../properties.json | 14 ------------ .../GHAConnectionError.class/README.md | 1 - .../methodProperties.json | 5 ----- .../TCIAccessDeniedError.class/README.md | 1 - .../class/accessDeniedMessage.st | 4 ---- .../instance/defaultAction.st | 4 ---- .../methodProperties.json | 5 ----- .../TCIConnectionError.class/README.md | 1 - .../instance/defaultAction.st | 5 ----- .../methodProperties.json | 5 ----- .../instance/updateJobLogForId..st | 7 ++++-- .../methodProperties.json | 2 +- .../instance/testValidateSlug.st | 22 +++++++++---------- .../methodProperties.json | 2 +- 48 files changed, 69 insertions(+), 101 deletions(-) delete mode 100644 packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st create mode 100644 packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st rename packages/AutoTDD-Core.package/{ATDDGitHubActionsClient.class => ATDDRemoteClient.class}/instance/throwExceptionForResponseCode..st (84%) delete mode 100644 packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st delete mode 100644 packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md rename packages/AutoTDD-Exceptions.package/{GHAAccessDeniedError.class/class/accessDeniedMessage.st => ATDDAccessDeniedError.class/class/message.st} (59%) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json rename packages/AutoTDD-Exceptions.package/{GHAConnectionError.class => ATDDAccessDeniedError.class}/properties.json (70%) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md rename packages/AutoTDD-Exceptions.package/{GHAConnectionError.class => ATDDConnectionError.class}/instance/defaultAction.st (100%) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json rename packages/AutoTDD-Exceptions.package/{TCIConnectionError.class => ATDDConnectionError.class}/properties.json (70%) rename packages/AutoTDD-Exceptions.package/{TCINoValidSlugError.class => ATDDNoValidSlugError.class}/README.md (100%) rename packages/AutoTDD-Exceptions.package/{TCINoValidSlugError.class => ATDDNoValidSlugError.class}/class/noValidSlugMessage.st (100%) rename packages/AutoTDD-Exceptions.package/{TCINoValidSlugError.class => ATDDNoValidSlugError.class}/instance/defaultAction.st (100%) rename packages/AutoTDD-Exceptions.package/{TCINoValidSlugError.class => ATDDNoValidSlugError.class}/methodProperties.json (100%) rename packages/AutoTDD-Exceptions.package/{TCIAccessDeniedError.class => ATDDNoValidSlugError.class}/properties.json (86%) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md create mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st create mode 100644 packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json rename packages/AutoTDD-Exceptions.package/{TCINoValidSlugError.class => ATDDNotFoundError.class}/properties.json (69%) delete mode 100644 packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md delete mode 100644 packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st delete mode 100644 packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json delete mode 100644 packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/properties.json delete mode 100644 packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md delete mode 100644 packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json delete mode 100644 packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md delete mode 100644 packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st delete mode 100644 packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st delete mode 100644 packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json delete mode 100644 packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md delete mode 100644 packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st delete mode 100644 packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st deleted file mode 100644 index 8bc0dd63..00000000 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st +++ /dev/null @@ -1,4 +0,0 @@ -constants -errorDictionary - - ^ IdentityDictionary newFrom: { 403 -> GHAAccessDeniedError } \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st index 5d282d29..c5933699 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st +++ b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st @@ -14,7 +14,7 @@ requestOn: aString response content; close ] on: Error do: [ :error | - [ GHAConnectionError signal: 'Connection failed: ' , error messageText ] fork. + [ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork. ^ JsonObject new ]. ^ response code = 200 diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json index 78f9a17f..47d9bb54 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json @@ -2,7 +2,6 @@ "class" : { }, "instance" : { - "errorDictionary" : "ng 5/26/2021 19:13", "getJsonForJobsForRepository:forWorkflowRunId:" : "BF 5/23/2021 21:30", "getJsonForLatestWorkflowRunForRepository:" : "ng 5/27/2021 19:07", "getJsonForWorkflow:" : "ng 5/23/2021 12:08", @@ -10,5 +9,4 @@ "getLogsForRepository:logId:" : "ng 5/27/2021 19:07", "gitHubActionsApiUrl" : "ng 5/14/2021 16:07", "mimeType" : "ng 5/14/2021 15:45", - "requestOn:" : "BF 5/28/2021 21:36", - "throwExceptionForResponseCode:" : "ng 5/26/2021 19:14" } } + "requestOn:" : "ng 6/18/2021 14:04" } } diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st new file mode 100644 index 00000000..ac440154 --- /dev/null +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st @@ -0,0 +1,7 @@ +accessing +errorDictionary + + ^ IdentityDictionary newFrom: { + 403 -> ATDDAccessDeniedError. + 404 -> ATDDNotFoundError + } \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/throwExceptionForResponseCode..st b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st similarity index 84% rename from packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/throwExceptionForResponseCode..st rename to packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st index 9659348d..3a994038 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/throwExceptionForResponseCode..st +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st @@ -1,4 +1,4 @@ -exception handling +accessing throwExceptionForResponseCode: aNumber ^ (self errorDictionary at: aNumber ifAbsent: [ Error ]) signal \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json index 14763a04..98d96b04 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json @@ -2,6 +2,8 @@ "class" : { }, "instance" : { + "errorDictionary" : "ng 6/18/2021 13:59", + "throwExceptionForResponseCode:" : "ng 6/18/2021 14:05", "token" : "ClassTest 6/2/2021 18:44", "token:" : "ClassTest 6/2/2021 18:44", "userAgent" : "ClassTest 6/2/2021 18:45", diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st deleted file mode 100644 index b040ad1b..00000000 --- a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st +++ /dev/null @@ -1,4 +0,0 @@ -constants -errorDictionary - - ^ IdentityDictionary newFrom: { 403 -> [ TCIAccessDeniedError signal ] } \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st index 3af8b77e..54329839 100644 --- a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st +++ b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st @@ -13,7 +13,7 @@ requestOn: aString response content; close ] on: Error do: [ :error | - [ TCIConnectionError signal: 'Connection failed: ' , error messageText ] fork. + [ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork. ^ JsonObject new ]. ^ response code diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st deleted file mode 100644 index b1dea21e..00000000 --- a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st +++ /dev/null @@ -1,4 +0,0 @@ -exception handling -throwExceptionForResponseCode: aNumber - - (self errorDictionary at: aNumber ifAbsent: [ [ ] ]) fork \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json index aa35cbc4..6517a8e1 100644 --- a/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json @@ -2,7 +2,6 @@ "class" : { }, "instance" : { - "errorDictionary" : "PS 7/25/2014 17:01", "getJsonForBuild:" : "CW 2/25/2016 10:14", "getJsonForBuildsOfRepository:" : "PS 5/19/2014 17:44", "getJsonForJob:" : "PS 5/19/2014 14:40", @@ -12,8 +11,7 @@ "isJson:" : "PS 6/11/2014 13:56", "mimeType" : "PS 5/18/2014 18:04", "requestAPIOn:" : "maf 12/5/2017 14:41", - "requestOn:" : "ls 7/25/2019 15:30", - "throwExceptionForResponseCode:" : "PS 6/23/2014 15:55", + "requestOn:" : "ng 6/18/2021 14:04", "travisApiUrl" : "PS 6/19/2014 09:57", "usePro" : "PS 6/19/2014 09:56", "usePro:" : "ls 7/25/2019 15:20" } } diff --git a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st index 9f615a85..e97bd82a 100644 --- a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st +++ b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st @@ -1,4 +1,4 @@ data-processing validate: aString - (aString matchesRegex: self class validSlug) ifFalse: [ TCINoValidSlugError signal ] \ No newline at end of file + (aString matchesRegex: self class validSlug) ifFalse: [ ATDDNoValidSlugError signal ] \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json index 41d5f1b5..93aa9fe2 100644 --- a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json @@ -29,5 +29,5 @@ "update" : "ls 7/11/2019 18:57", "usePro" : "ls 6/5/2019 21:10", "usePro:" : "ls 7/25/2019 14:13", - "validate:" : "vxr 7/4/2019 14:25", + "validate:" : "ng 6/18/2021 14:06", "wrapAsJson:" : "vxr 7/4/2019 14:25" } } diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md new file mode 100644 index 00000000..e69de29b diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/class/accessDeniedMessage.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st similarity index 59% rename from packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/class/accessDeniedMessage.st rename to packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st index 7a0040e6..fb1c10b7 100644 --- a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/class/accessDeniedMessage.st +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/message.st @@ -1,4 +1,4 @@ accessing -accessDeniedMessage +message ^ 'Access denied' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st new file mode 100644 index 00000000..11f69e80 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st @@ -0,0 +1,4 @@ +priv handling +defaultAction + + ^ Transcript show: self class message \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json new file mode 100644 index 00000000..a5e2ba8e --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json @@ -0,0 +1,5 @@ +{ + "class" : { + "message" : "ng 6/18/2021 13:55" }, + "instance" : { + "defaultAction" : "ng 6/18/2021 13:53" } } diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json similarity index 70% rename from packages/AutoTDD-Exceptions.package/GHAConnectionError.class/properties.json rename to packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json index eba09c76..142be7ee 100644 --- a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json @@ -4,10 +4,10 @@ ], "classvars" : [ ], - "commentStamp" : "ng 5/28/2021 14:45", + "commentStamp" : "", "instvars" : [ ], - "name" : "GHAConnectionError", + "name" : "ATDDAccessDeniedError", "pools" : [ ], "super" : "Error", diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md new file mode 100644 index 00000000..e69de29b diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st similarity index 100% rename from packages/AutoTDD-Exceptions.package/GHAConnectionError.class/instance/defaultAction.st rename to packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/instance/defaultAction.st diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json new file mode 100644 index 00000000..fe2abe06 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json @@ -0,0 +1,5 @@ +{ + "class" : { + }, + "instance" : { + "defaultAction" : "ng 6/18/2021 14:03" } } diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json similarity index 70% rename from packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json rename to packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json index 6a43a8ec..f552ce0d 100644 --- a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json @@ -4,10 +4,10 @@ ], "classvars" : [ ], - "commentStamp" : "be 7/25/2019 10:28", + "commentStamp" : "", "instvars" : [ ], - "name" : "TCIConnectionError", + "name" : "ATDDConnectionError", "pools" : [ ], "super" : "Error", diff --git a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/README.md similarity index 100% rename from packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/README.md rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/README.md diff --git a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/class/noValidSlugMessage.st b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/noValidSlugMessage.st similarity index 100% rename from packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/class/noValidSlugMessage.st rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/class/noValidSlugMessage.st diff --git a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st similarity index 100% rename from packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/instance/defaultAction.st rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/instance/defaultAction.st diff --git a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json similarity index 100% rename from packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/methodProperties.json rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/methodProperties.json diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json similarity index 86% rename from packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/properties.json rename to packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json index b1dceb5d..823c9623 100644 --- a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNoValidSlugError.class/properties.json @@ -7,7 +7,7 @@ "commentStamp" : "be 7/25/2019 10:29", "instvars" : [ ], - "name" : "TCIAccessDeniedError", + "name" : "ATDDNoValidSlugError", "pools" : [ ], "super" : "Error", diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md new file mode 100644 index 00000000..e69de29b diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st new file mode 100644 index 00000000..22e2867a --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st @@ -0,0 +1,4 @@ +accessing +message + + ^ 'Not Found' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st new file mode 100644 index 00000000..11f69e80 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st @@ -0,0 +1,4 @@ +priv handling +defaultAction + + ^ Transcript show: self class message \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json new file mode 100644 index 00000000..ccc57556 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json @@ -0,0 +1,5 @@ +{ + "class" : { + "message" : "ng 6/18/2021 13:55" }, + "instance" : { + "defaultAction" : "ng 6/18/2021 13:59" } } diff --git a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json similarity index 69% rename from packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/properties.json rename to packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json index f1737e02..3c251f68 100644 --- a/packages/AutoTDD-Exceptions.package/TCINoValidSlugError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json @@ -4,10 +4,10 @@ ], "classvars" : [ ], - "commentStamp" : "be 7/25/2019 10:29", + "commentStamp" : "", "instvars" : [ ], - "name" : "TCINoValidSlugError", + "name" : "ATDDNotFoundError", "pools" : [ ], "super" : "Error", diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md deleted file mode 100644 index d9ff557d..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md +++ /dev/null @@ -1 +0,0 @@ -A GHAAccessDeniedError is the exception thrown when access to the repository has been denied. diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st deleted file mode 100644 index 20b1e1e4..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st +++ /dev/null @@ -1,4 +0,0 @@ -priv handling -defaultAction - - ^ Transcript show: self class accessDeniedMessage \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json deleted file mode 100644 index 5e2a8ba1..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "class" : { - "accessDeniedMessage" : "ng 5/26/2021 18:03" }, - "instance" : { - "defaultAction" : "swi 7/25/2019 14:21" } } diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/properties.json b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/properties.json deleted file mode 100644 index f30b3a22..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/properties.json +++ /dev/null @@ -1,14 +0,0 @@ -{ - "category" : "AutoTDD-Exceptions", - "classinstvars" : [ - ], - "classvars" : [ - ], - "commentStamp" : "ng 5/28/2021 14:44", - "instvars" : [ - ], - "name" : "GHAAccessDeniedError", - "pools" : [ - ], - "super" : "Error", - "type" : "normal" } diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md deleted file mode 100644 index e8f4e65e..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md +++ /dev/null @@ -1 +0,0 @@ -A GHAConnectionError is the exception thrown when an error during connecting occurs. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json deleted file mode 100644 index b9e9b04b..00000000 --- a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "class" : { - }, - "instance" : { - "defaultAction" : "ng 5/14/2021 15:31" } } diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md deleted file mode 100644 index 73f0372f..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md +++ /dev/null @@ -1 +0,0 @@ -A TCIAccessDeniedError is the exception thrown when access to the repository has been denied. diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st deleted file mode 100644 index be9dcafd..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st +++ /dev/null @@ -1,4 +0,0 @@ -accessing -accessDeniedMessage - - ^ 'Access denied' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st deleted file mode 100644 index 20b1e1e4..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st +++ /dev/null @@ -1,4 +0,0 @@ -priv handling -defaultAction - - ^ Transcript show: self class accessDeniedMessage \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json deleted file mode 100644 index 0674cca2..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "class" : { - "accessDeniedMessage" : "swi 7/25/2019 14:21" }, - "instance" : { - "defaultAction" : "swi 7/25/2019 14:21" } } diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md deleted file mode 100644 index 9fb9ec5c..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md +++ /dev/null @@ -1 +0,0 @@ -A TCIConnectionError is the exception thrown when an error during connecting occurs. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st deleted file mode 100644 index 130a20a8..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st +++ /dev/null @@ -1,5 +0,0 @@ -priv handling -defaultAction - "UIManager default inform: self messageText" - - ^ Transcript show: self messageText \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json deleted file mode 100644 index 2692d9d4..00000000 --- a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "class" : { - }, - "instance" : { - "defaultAction" : "vxr 7/4/2019 15:01" } } diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st index 67580d45..00d4559c 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st @@ -4,9 +4,12 @@ updateJobLogForId: aNumber | response | [ response := self data client getLogsForRepository: self data repository logId: aNumber ] - on: GHAAccessDeniedError - do: [ :error | response := 'Acces denied. Logs are only available when providing a token' ]. + on: ATDDAccessDeniedError + do: [ :error | response := error class message , '. Logs are only available when providing a token.' ]; + on: ATDDNotFoundError + do: [ :error | response := error class message , '. No logs available for this workflow.' ]. + (self isSmalltalkCILog: response) ifTrue: [response := self parseSmalltalkCILog: response]. diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json index 5c6a4ad4..4d506a40 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json @@ -15,5 +15,5 @@ "parseAnsiCodeOf:" : "BF 6/11/2021 21:15", "parseSmalltalkCILog:" : "BF 6/11/2021 19:48", "selectedJob:" : "ng 5/26/2021 14:54", - "updateJobLogForId:" : "BF 6/11/2021 13:43", + "updateJobLogForId:" : "ng 6/18/2021 14:30", "updateJobs" : "ClassTest 5/29/2021 19:12" } } diff --git a/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/instance/testValidateSlug.st b/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/instance/testValidateSlug.st index 185a00a0..d508d974 100644 --- a/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/instance/testValidateSlug.st +++ b/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/instance/testValidateSlug.st @@ -2,14 +2,14 @@ tests testValidateSlug self - shouldnt: [ repository repository: 'a/b' ] raise: TCINoValidSlugError; - shouldnt: [ repository repository: 'a0/-b' ] raise: TCINoValidSlugError; - should: [ repository repository: 'a/' ] raise: TCINoValidSlugError; - should: [ repository repository: '/b' ] raise: TCINoValidSlugError; - should: [ repository repository: '/' ] raise: TCINoValidSlugError; - should: [ repository repository: 'a /b' ] raise: TCINoValidSlugError; - should: [ repository repository: 'a/ b' ] raise: TCINoValidSlugError; - should: [ repository repository: ' a/b' ] raise: TCINoValidSlugError; - should: [ repository repository: 'a/b ' ] raise: TCINoValidSlugError; - should: [ repository repository: 'a/b/c' ] raise: TCINoValidSlugError; - should: [ repository repository: 'ab' ] raise: TCINoValidSlugError \ No newline at end of file + shouldnt: [ repository repository: 'a/b' ] raise: ATDDNoValidSlugError; + shouldnt: [ repository repository: 'a0/-b' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'a/' ] raise: ATDDNoValidSlugError; + should: [ repository repository: '/b' ] raise: ATDDNoValidSlugError; + should: [ repository repository: '/' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'a /b' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'a/ b' ] raise: ATDDNoValidSlugError; + should: [ repository repository: ' a/b' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'a/b ' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'a/b/c' ] raise: ATDDNoValidSlugError; + should: [ repository repository: 'ab' ] raise: ATDDNoValidSlugError \ No newline at end of file diff --git a/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/methodProperties.json b/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/methodProperties.json index 7b721c59..1b67d072 100644 --- a/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/methodProperties.json +++ b/packages/AutoTDD-Tests.package/ATDDTravisRepositoryTest.class/methodProperties.json @@ -4,4 +4,4 @@ "instance" : { "setUp" : "ls 7/25/2019 09:43", "testInitialization" : "PS 6/24/2014 17:10", - "testValidateSlug" : "PS 7/25/2014 17:02" } } + "testValidateSlug" : "ng 6/18/2021 14:09" } } From 4aa03bc5455c075271342abb5041859f6eda16a1 Mon Sep 17 00:00:00 2001 From: kolioOtSofia Date: Fri, 18 Jun 2021 15:11:09 +0300 Subject: [PATCH 2/5] adding stuff --- .../ATDDGitHubAction.class/instance/pause.st | 5 +++++ .../methodProperties.json | 1 + .../instance/errorDictionary.st | 1 + .../methodProperties.json | 2 +- .../instance/pause.st | 3 +-- .../methodProperties.json | 2 +- .../ATDDTravisStatus.class/instance/pause.st | 5 +++++ .../methodProperties.json | 1 + .../instance/resumeGitHubAction..st | 4 +++- .../ATDDBrowser.class/methodProperties.json | 2 +- .../instance/hasValidUrl.st | 12 ++++++++++ .../instance/save.st | 22 +++++++++++++++++++ .../methodProperties.json | 4 +++- .../instance/updateJobLogForId..st | 2 +- .../methodProperties.json | 2 +- 15 files changed, 59 insertions(+), 9 deletions(-) create mode 100644 packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st create mode 100644 packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st create mode 100644 packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st create mode 100644 packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st diff --git a/packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st new file mode 100644 index 00000000..c4e6f351 --- /dev/null +++ b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st @@ -0,0 +1,5 @@ +behaviour +pause + + super pause. + ATDDBrowser changedGitHubActions \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json index a965f862..a68871e3 100644 --- a/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json @@ -6,6 +6,7 @@ "symbol" : "sw 5/25/2021 22:27" }, "instance" : { "initialize" : "BF 5/23/2021 21:18", + "pause" : "ng 6/18/2021 14:47", "repositoryURL:" : "BF 5/23/2021 21:29", "statusChanged" : "ClassTest 5/29/2021 19:31", "updateStatus" : "ClassTest 5/28/2021 23:47" } } diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st index ac440154..8802f458 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st @@ -2,6 +2,7 @@ accessing errorDictionary ^ IdentityDictionary newFrom: { + 401 -> ATDDConnectionError. 403 -> ATDDAccessDeniedError. 404 -> ATDDNotFoundError } \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json index 98d96b04..decf1de1 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json @@ -2,7 +2,7 @@ "class" : { }, "instance" : { - "errorDictionary" : "ng 6/18/2021 13:59", + "errorDictionary" : "ng 6/18/2021 14:48", "throwExceptionForResponseCode:" : "ng 6/18/2021 14:05", "token" : "ClassTest 6/2/2021 18:44", "token:" : "ClassTest 6/2/2021 18:44", diff --git a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st index c3ade4a5..b07200ba 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st +++ b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st @@ -2,5 +2,4 @@ behaviour pause self terminateProcess. - super pause. - self updateStatus \ No newline at end of file + super pause \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json index ed769793..65ee441e 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json @@ -7,7 +7,7 @@ "internalStatus" : "ClassTest 6/2/2021 17:54", "internalStatus:" : "ClassTest 5/29/2021 19:42", "newRefreshProcess" : "sw 5/28/2021 18:04", - "pause" : "sw 5/28/2021 18:04", + "pause" : "ng 6/18/2021 14:46", "pausedString" : "sw 5/28/2021 18:04", "process" : "sw 5/28/2021 18:06", "process:" : "sw 5/28/2021 18:06", diff --git a/packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st new file mode 100644 index 00000000..bb5a9fe3 --- /dev/null +++ b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st @@ -0,0 +1,5 @@ +behaviour +pause + + super pause. + ATDDBrowser changedTravisStatuses \ No newline at end of file diff --git a/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json index 6662e485..ad7beb68 100644 --- a/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json +++ b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json @@ -6,6 +6,7 @@ "symbol" : "sw 5/25/2021 22:21" }, "instance" : { "initialize" : "BF 5/23/2021 21:18", + "pause" : "ng 6/18/2021 14:49", "repositoryURL:" : "ls 7/25/2019 09:23", "statusChanged" : "ClassTest 5/29/2021 19:36", "updateStatus" : "ClassTest 5/28/2021 23:46", diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st index 8492197c..d43946d4 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st @@ -1,4 +1,6 @@ action resumeGitHubAction: aGitHubAction - aGitHubAction resume \ No newline at end of file + [ aGitHubAction resume ] + on: ATDDAccessDeniedError + do: [UIManager default inform: 'test' ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json index 7fcd1aab..1ab51ff2 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json @@ -93,7 +93,7 @@ "resultsTravisStatuses" : "sw 5/26/2021 00:07", "resultsWatchers" : "sw 5/26/2021 00:07", "resumeAll" : "sw 5/21/2021 21:05", - "resumeGitHubAction:" : "sw 5/21/2021 21:04", + "resumeGitHubAction:" : "ng 6/18/2021 15:03", "resumeSelectedGitHubActions" : "sw 5/21/2021 22:17", "resumeSelectedTravisStatuses" : "swi 7/25/2019 15:30", "resumeSelectedWatchers" : "swi 7/25/2019 15:31", diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st new file mode 100644 index 00000000..a96e4f2a --- /dev/null +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st @@ -0,0 +1,12 @@ +action +hasValidUrl + + | client | + + client := ATDDGitHubActionsClient new. + client token: self token. + [ client requestOn: 'repos/' , self repositoryUrl ] + on: ATDDNotFoundError + do: [ ^ false ]. + + ^ true \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st new file mode 100644 index 00000000..03b79a36 --- /dev/null +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/save.st @@ -0,0 +1,22 @@ +action +save + + repositoryUrl changed: #acceptChanges. + token changed: #acceptChanges. + refreshInterval changed: #acceptChanges. + self hasVaildRefreshInterval + ifFalse: [ + UIManager default inform: 'Please enter a valid interval!'. + ^ nil ]. + self hasVaildSlug + ifFalse: [ + UIManager default inform: 'Please enter a valid slug!'. + ^ nil ]. + self hasValidUrl + ifFalse: [ + UIManager default inform: 'Error 404! Please provide a valid {owner}/{repo}'. + ^ nil ]. + super save. + self closeWindow. + + ^ self applyChanges \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json index 68899d65..06e5b757 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json @@ -11,4 +11,6 @@ "validSlug" : "BF 5/21/2021 14:07" }, "instance" : { "applyChanges" : "sw 5/25/2021 20:21", - "gitHubAction" : "sw 5/25/2021 19:21" } } + "gitHubAction" : "sw 5/25/2021 19:21", + "hasValidUrl" : "ng 6/18/2021 14:52", + "save" : "ng 6/18/2021 14:53" } } diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st index 00d4559c..14c8980b 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobLogForId..st @@ -5,7 +5,7 @@ updateJobLogForId: aNumber [ response := self data client getLogsForRepository: self data repository logId: aNumber ] on: ATDDAccessDeniedError - do: [ :error | response := error class message , '. Logs are only available when providing a token.' ]; + do: [ :error | response := error class message , '. Logs are only available when providing a token.' ] on: ATDDNotFoundError do: [ :error | response := error class message , '. No logs available for this workflow.' ]. diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json index 4d506a40..759f3c0c 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json @@ -15,5 +15,5 @@ "parseAnsiCodeOf:" : "BF 6/11/2021 21:15", "parseSmalltalkCILog:" : "BF 6/11/2021 19:48", "selectedJob:" : "ng 5/26/2021 14:54", - "updateJobLogForId:" : "ng 6/18/2021 14:30", + "updateJobLogForId:" : "ng 6/18/2021 14:43", "updateJobs" : "ClassTest 5/29/2021 19:12" } } From 2de178a92a8ca61fbc0432b2b74c76c95356fe79 Mon Sep 17 00:00:00 2001 From: Benjamin Frost Date: Fri, 18 Jun 2021 14:55:03 +0200 Subject: [PATCH 3/5] Finish Exception Handling --- .../ATDDAccessDeniedError.class/class/rateLimitMessage.st | 4 ++++ .../ATDDAccessDeniedError.class/methodProperties.json | 3 ++- .../ATDDBrowser.class/instance/refreshGitHubAction..st | 7 ++++++- .../ATDDBrowser.class/instance/resumeGitHubAction..st | 5 ++++- .../ATDDBrowser.class/methodProperties.json | 4 ++-- .../ATDDGitHubActionEditor.class/instance/applyChanges.st | 4 +++- .../ATDDGitHubActionEditor.class/instance/hasValidUrl.st | 5 ++++- .../ATDDGitHubActionEditor.class/methodProperties.json | 4 ++-- .../ATDDGitHubActionResults.class/instance/updateJobs.st | 2 +- .../ATDDGitHubActionResults.class/methodProperties.json | 2 +- 10 files changed, 29 insertions(+), 11 deletions(-) create mode 100644 packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st new file mode 100644 index 00000000..05b867e8 --- /dev/null +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st @@ -0,0 +1,4 @@ +accessing +rateLimitMessage + + ^ 'You have been rate-limited. This GitHub Action will now be paused. Consider providing a token to prevent this.' \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json index a5e2ba8e..e4753196 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json @@ -1,5 +1,6 @@ { "class" : { - "message" : "ng 6/18/2021 13:55" }, + "message" : "ng 6/18/2021 13:55", + "rateLimitMessage" : "BF 6/18/2021 14:51" }, "instance" : { "defaultAction" : "ng 6/18/2021 13:53" } } diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st index 75b4d466..313bbe06 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st @@ -1,4 +1,9 @@ action refreshGitHubAction: aGitHubAction - aGitHubAction refresh \ No newline at end of file + [ aGitHubAction refresh ] + on: ATDDAccessDeniedError + do: [ + UIManager default inform: ATDDAccessDeniedError rateLimitMessage. + self pauseTestingEntity: aGitHubAction + ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st index d43946d4..054931d9 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st @@ -3,4 +3,7 @@ resumeGitHubAction: aGitHubAction [ aGitHubAction resume ] on: ATDDAccessDeniedError - do: [UIManager default inform: 'test' ] \ No newline at end of file + do: [ + UIManager default inform: ATDDAccessDeniedError rateLimitMessage. + self pauseTestingEntity: aGitHubAction + ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json index 1ab51ff2..ec51c991 100644 --- a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json @@ -79,7 +79,7 @@ "pauseTestingEntity:" : "sw 5/28/2021 15:17", "pauseTravisStatuses" : "sw 5/26/2021 00:03", "pauseWatchers" : "sw 5/26/2021 00:04", - "refreshGitHubAction:" : "sw 5/21/2021 21:01", + "refreshGitHubAction:" : "BF 6/18/2021 14:51", "refreshSelectedGitHubActions" : "sw 5/21/2021 21:02", "refreshSelectedTravisStatuses" : "swi 7/10/2019 14:03", "refreshTravisStatus:" : "swi 7/10/2019 14:03", @@ -93,7 +93,7 @@ "resultsTravisStatuses" : "sw 5/26/2021 00:07", "resultsWatchers" : "sw 5/26/2021 00:07", "resumeAll" : "sw 5/21/2021 21:05", - "resumeGitHubAction:" : "ng 6/18/2021 15:03", + "resumeGitHubAction:" : "BF 6/18/2021 14:51", "resumeSelectedGitHubActions" : "sw 5/21/2021 22:17", "resumeSelectedTravisStatuses" : "swi 7/25/2019 15:30", "resumeSelectedWatchers" : "swi 7/25/2019 15:31", diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st index d96ebfa0..f22dd803 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st @@ -3,4 +3,6 @@ applyChanges super applyChanges. - self gitHubAction resume \ No newline at end of file + [ self gitHubAction resume ] + on: ATDDAccessDeniedError + do: [ self gitHubAction pause ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st index a96e4f2a..36825b77 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st @@ -6,7 +6,10 @@ hasValidUrl client := ATDDGitHubActionsClient new. client token: self token. [ client requestOn: 'repos/' , self repositoryUrl ] + on: ATDDAccessDeniedError + do: [ UIManager default inform: ATDDAccessDeniedError rateLimitMessage. ] on: ATDDNotFoundError do: [ ^ false ]. - ^ true \ No newline at end of file + ^ true + diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json index 06e5b757..472eee92 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/methodProperties.json @@ -10,7 +10,7 @@ "tokenHelpLabel" : "sw 5/25/2021 20:51", "validSlug" : "BF 5/21/2021 14:07" }, "instance" : { - "applyChanges" : "sw 5/25/2021 20:21", + "applyChanges" : "BF 6/18/2021 14:54", "gitHubAction" : "sw 5/25/2021 19:21", - "hasValidUrl" : "ng 6/18/2021 14:52", + "hasValidUrl" : "BF 6/18/2021 14:52", "save" : "ng 6/18/2021 14:53" } } diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobs.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobs.st index 668761d3..4888242a 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobs.st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/instance/updateJobs.st @@ -4,7 +4,7 @@ updateJobs | id jobs | id := self parser parseIdOfWorkflowAt: self selectedHistory ofWorkflowsOfRepository: self data repositoryJson. - jobs := self parser parseJobsOf: ( self data client getJsonForJobsForRepository: (self data repository , '/') forWorkflowRunId: id ). + jobs := self parser parseJobsOf: (self data client getJsonForJobsForRepository: (self data repository , '/') forWorkflowRunId: id). self jobs: (jobs collect: [ :job | ATDDGitHubActionWorkflowJob newForId: (parser primitiveParseIdOf: job) name: (parser primitiveParseNameOf: job) diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json index 759f3c0c..b8071505 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionResults.class/methodProperties.json @@ -16,4 +16,4 @@ "parseSmalltalkCILog:" : "BF 6/11/2021 19:48", "selectedJob:" : "ng 5/26/2021 14:54", "updateJobLogForId:" : "ng 6/18/2021 14:43", - "updateJobs" : "ClassTest 5/29/2021 19:12" } } + "updateJobs" : "BF 6/18/2021 14:41" } } From 8156cb84f96c12a2d2ded1b211a508558e8a1611 Mon Sep 17 00:00:00 2001 From: Benjamin Frost Date: Sat, 19 Jun 2021 10:43:01 +0200 Subject: [PATCH 4/5] Small Improvements --- .../instance/throwExceptionForResponseCode..st | 2 +- .../ATDDAccessDeniedError.class/README.md | 1 + .../ATDDAccessDeniedError.class/properties.json | 2 +- .../ATDDConnectionError.class/README.md | 1 + .../ATDDConnectionError.class/properties.json | 2 +- .../ATDDNotFoundError.class/README.md | 1 + .../ATDDNotFoundError.class/properties.json | 2 +- .../ATDDGitHubActionEditor.class/instance/hasValidUrl.st | 2 +- .../ATDDRemoteEditor.class/instance/applyChanges.st | 2 +- .../ATDDRemoteEditor.class/instance/buildInputFieldsWith..st | 2 +- .../ATDDRemoteEditor.class/instance/buildIntervalWith..st | 2 +- .../ATDDRemoteEditor.class/instance/buildRepositoryUrlWith..st | 2 +- .../ATDDRemoteEditor.class/instance/buildTokenWith..st | 2 +- .../ATDDRemoteEditor.class/instance/hasVaildRefreshInterval.st | 2 +- .../ATDDRemoteEditor.class/instance/hasVaildSlug.st | 2 +- .../ATDDRemoteEditor.class/instance/initializeInputFields.st | 2 +- .../ATDDRemoteEditor.class/instance/initializeInterval.st | 2 +- .../ATDDRemoteEditor.class/instance/initializeRepositoryUrl.st | 2 +- .../ATDDRemoteEditor.class/instance/initializeToken.st | 2 +- .../ATDDRemoteEditor.class/instance/intervalFrame.st | 2 +- .../ATDDRemoteEditor.class/instance/loadTargetSpecs.st | 2 +- .../ATDDRemoteEditor.class/instance/repositoryUrlFrame.st | 2 +- .../AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st | 2 +- .../ATDDRemoteEditor.class/instance/targetNameFrame.st | 2 +- .../ATDDRemoteEditor.class/instance/tokenFrame.st | 2 +- 25 files changed, 25 insertions(+), 22 deletions(-) diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st index 3a994038..9659348d 100644 --- a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st +++ b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st @@ -1,4 +1,4 @@ -accessing +exception handling throwExceptionForResponseCode: aNumber ^ (self errorDictionary at: aNumber ifAbsent: [ Error ]) signal \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md index e69de29b..a5db5bd0 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md @@ -0,0 +1 @@ +An ATDDAccessDeniedError is thrown when the HTTP request results in a 403 (Forbidden) Error. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json index 142be7ee..8ef90454 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/properties.json @@ -4,7 +4,7 @@ ], "classvars" : [ ], - "commentStamp" : "", + "commentStamp" : "BF 6/19/2021 10:35", "instvars" : [ ], "name" : "ATDDAccessDeniedError", diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md index e69de29b..2969b35b 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md @@ -0,0 +1 @@ +An ATDDConnectionError is thrown when the HTTP request results in a 401 (Unauthorized) Error. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json index f552ce0d..6ef81be3 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/properties.json @@ -4,7 +4,7 @@ ], "classvars" : [ ], - "commentStamp" : "", + "commentStamp" : "BF 6/19/2021 10:35", "instvars" : [ ], "name" : "ATDDConnectionError", diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md index e69de29b..2c4fccd4 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md @@ -0,0 +1 @@ +An ATDDNotFoundError is thrown when the HTTP request results in a 404 (Not Found) Error. \ No newline at end of file diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json index 3c251f68..7b31a132 100644 --- a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json +++ b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/properties.json @@ -4,7 +4,7 @@ ], "classvars" : [ ], - "commentStamp" : "", + "commentStamp" : "BF 6/19/2021 10:36", "instvars" : [ ], "name" : "ATDDNotFoundError", diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st index 36825b77..75888ae5 100644 --- a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st +++ b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st @@ -1,4 +1,4 @@ -action +testing hasValidUrl | client | diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st index 6faca122..1bd00c9b 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st @@ -1,4 +1,4 @@ -accessing +behavior applyChanges super applyChanges. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildInputFieldsWith..st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildInputFieldsWith..st index 2237ed6a..87c61d6c 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildInputFieldsWith..st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildInputFieldsWith..st @@ -1,4 +1,4 @@ -accessing +building buildInputFieldsWith: aBuilder ^ OrderedCollection new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildIntervalWith..st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildIntervalWith..st index a1126aa7..a4c4f6e5 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildIntervalWith..st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildIntervalWith..st @@ -1,4 +1,4 @@ -accessing +building buildIntervalWith: aBuilder ^ aBuilder pluggableInputFieldSpec new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildRepositoryUrlWith..st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildRepositoryUrlWith..st index 1dc5c494..29778423 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildRepositoryUrlWith..st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildRepositoryUrlWith..st @@ -1,4 +1,4 @@ -accessing +building buildRepositoryUrlWith: aBuilder ^ aBuilder pluggableInputFieldSpec new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildTokenWith..st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildTokenWith..st index 23b33b3f..69093fa4 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildTokenWith..st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/buildTokenWith..st @@ -1,4 +1,4 @@ -accessing +building buildTokenWith: aBuilder ^ aBuilder pluggableInputFieldSpec new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildRefreshInterval.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildRefreshInterval.st index 06e9717b..28cce641 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildRefreshInterval.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildRefreshInterval.st @@ -1,4 +1,4 @@ -accessing +testing hasVaildRefreshInterval ^ refreshInterval contents asString isAllDigits and: [ refreshInterval contents asString isEmpty not ] \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildSlug.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildSlug.st index 5471076a..4794fc23 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildSlug.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/hasVaildSlug.st @@ -1,4 +1,4 @@ -accessing +testing hasVaildSlug ^ self repositoryUrl asString matchesRegex: self class validSlug \ No newline at end of file diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInputFields.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInputFields.st index 859159c7..002682d0 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInputFields.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInputFields.st @@ -1,4 +1,4 @@ -accessing +initialization initializeInputFields super initializeInputFields. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInterval.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInterval.st index 25793a40..d81b5ed4 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInterval.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeInterval.st @@ -1,4 +1,4 @@ -accessing +initialization initializeInterval refreshInterval := ValueHolder new contents: ''. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeRepositoryUrl.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeRepositoryUrl.st index 084428c6..16e17649 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeRepositoryUrl.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeRepositoryUrl.st @@ -1,4 +1,4 @@ -accessing +initialization initializeRepositoryUrl repositoryUrl := ValueHolder new contents: ''. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeToken.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeToken.st index dbbd0cc7..c01a7496 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeToken.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/initializeToken.st @@ -1,4 +1,4 @@ -accessing +initialization initializeToken token := ValueHolder new contents: ''. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/intervalFrame.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/intervalFrame.st index 790ef731..e7c7d104 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/intervalFrame.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/intervalFrame.st @@ -1,4 +1,4 @@ -accessing +building intervalFrame ^ LayoutFrame new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st index 4ab78506..e254a2fe 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st @@ -1,4 +1,4 @@ -accessing +behavior loadTargetSpecs self diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/repositoryUrlFrame.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/repositoryUrlFrame.st index 43df5572..1bf1f351 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/repositoryUrlFrame.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/repositoryUrlFrame.st @@ -1,4 +1,4 @@ -accessing +building repositoryUrlFrame ^ LayoutFrame new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st index ec247194..a5a7b017 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st @@ -1,4 +1,4 @@ -accessing +behavior save repositoryUrl changed: #acceptChanges. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/targetNameFrame.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/targetNameFrame.st index 65a9fca5..3bb86448 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/targetNameFrame.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/targetNameFrame.st @@ -1,4 +1,4 @@ -accessing +building targetNameFrame ^ LayoutFrame new diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/tokenFrame.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/tokenFrame.st index b17649ef..00904349 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/tokenFrame.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/tokenFrame.st @@ -1,4 +1,4 @@ -accessing +building tokenFrame ^ LayoutFrame new From e5955e82993f7c007598334f00d9fcfa9e415965 Mon Sep 17 00:00:00 2001 From: Benjamin Frost Date: Sun, 20 Jun 2021 16:27:59 +0200 Subject: [PATCH 5/5] Recategorize --- .../ATDDRemoteEditor.class/instance/applyChanges.st | 2 +- .../ATDDRemoteEditor.class/instance/loadTargetSpecs.st | 2 +- .../AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st index 1bd00c9b..cf826387 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st @@ -1,4 +1,4 @@ -behavior +action applyChanges super applyChanges. diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st index e254a2fe..6c6128e4 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st @@ -1,4 +1,4 @@ -behavior +action loadTargetSpecs self diff --git a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st index a5a7b017..f1af1c87 100644 --- a/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st +++ b/packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st @@ -1,4 +1,4 @@ -behavior +action save repositoryUrl changed: #acceptChanges.