-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define 'system' toolchain, deprecate 'dummy' toolchain (WIP) #1233
Conversation
Refer to this link for build results (access rights to CI server needed): |
|
||
# deliberately not picking particular compilers | ||
COMPILER_CC = '%sCC' % TC_CONSTANT_SYSTEM | ||
COMPILER_CXX = '%sCXX' % TC_CONSTANT_SYSTEM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, EB will not set $CC
or $CXX
right? The user can choose which system compiler to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and I'm not sure if we shouldn't add a SystemGCC TC to specifically pick GCC and populate $CC and friends and set them to the same values as for the GCC TC.
But I would tend to leave it as it here. This basically reflects what people have been using dummy for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, EB
will set $CC
to SYSTEMCC
, which mimics with dummy
was doing. Maybe we shouldn't set it at all.
Introducing a separate SystemGCC
may be interesting, but wouldn't buy us much I think (people have no trouble in using dummy
even though EB sets $CC
to DUMMYCC
, so in practice setting $CC
makes little difference, apparently).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect that the system toolchain doesn't define $CC
or $CXX
at all. Any code build with it, should try to find it's own compiler using whatever build system it has. The end user should be able to choose what to do by setting $CC
(choosing between clang and gcc for example) and EB will not touch that.
I'm not a fan of having a SystemGCC
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have the system TC expose a module that a site can customize to fit the needs to set $CC et al. ?
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
While you are at it, I'd argue too that the new |
@damianam To get dependencies loaded when using the |
That's very intuitive, I don't know how I missed that ;-P. Thanks! |
replaced by #2877 |
TODO:
dummy
via--from-pr
)dummy
still works (and will keep working until v3.0)