-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for only (re)generating module file #1018
Conversation
skip = True | ||
# allow skipping sanity check too when only generating module via --force | ||
elif build_option('only_module') and step == 'sanitycheck' and build_option('force'): | ||
self.log.info("Skipping %s step, due to combo of --only-module and --force" in ['sanitycheck']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's with the info message? it just does self.log.info(False)
Conflicts: easybuild/main.py easybuild/tools/config.py easybuild/tools/options.py
@@ -1580,7 +1591,11 @@ def sanity_check_step(self, custom_paths=None, custom_commands=None, extension=F | |||
self.log.warning("Sanity check: %s" % self.sanity_check_fail_msgs[-1]) | |||
|
|||
# chdir to installdir (better environment for running tests) | |||
os.chdir(self.installdir) | |||
if os.path.exists(self.installdir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be isdi,
and there should be an else block with some error
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Remarks fixed, this looks a lot cleaner now, thanks for the suggestions @stdweird! I'll tackle documentation updates all in one go (while regtest is running). |
add support for only (re)generating module file
Copying an oneliner from today's IRC bubbles, showing where this is heading to: |
@fgeorgatos: that's only partially relevant anymore, since |
This adds support for only (re)generating a module file. The sanity check is still run, to make sure that the software installation was already taken care of, unless
--force
is used, then you can also generate for non-existing installations (which is great when experimenting with a particular module naming scheme).One thing which is not possible (yet) with this is to generate module files for existing installations using a different module naming scheme, since the installation prefix always matches the module name being used.
This could probably be fixed as well, but needs extra logic and probably and extra command line parameter, to specify using which naming scheme an existing installation was installed (so the software installation prefix can be found).