Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

More robust handling of Slack API requests #627

Closed
slambdin1 opened this issue Jan 25, 2017 · 1 comment
Closed

More robust handling of Slack API requests #627

slambdin1 opened this issue Jan 25, 2017 · 1 comment
Labels
enhancement Slack-related

Comments

@slambdin1
Copy link

According to their docs...

Callers should always check the value of the ok params in the response.

Therefore, even if you make a request and it returns 200, it isn't guaranteed that you will receive a JSON object that you expect. It would be nice to see this reflected in the call_api method here.
@peterswimm
Copy link
Contributor

This has been handled #387

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Slack-related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterswimm @slambdin1