Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a toolchain with a date nightly-2023-09-30 and a rust-toolchain.toml #27

Closed
tombh opened this issue Oct 13, 2024 · 2 comments

Comments

@tombh
Copy link

tombh commented Oct 13, 2024

Here's the error, note that it is for aarch64-unknown-linux-gnu even though the generated toolchain name is for x86_64-unknown-linux-gnu:

Run /home/runner/work/_temp/cross +nightly-2023-09-30 build --locked --release --target aarch64-unknown-linux-gnu
error: error: invalid value 'nightly-2023-09-30-2023-09-30-x86_64-unknown-linux-gnu' for '<toolchain>...': invalid toolchain name: 'nightly-2023-09-30-2023-09-30-x86_64-unknown-linux-gnu'

Full logs: https://github.com/tombh/rust-gpu-cli/actions/runs/11317667123/job/31471379599#step:4:714

It looks like cross honours rust-toolchain.toml and correctly provides the toolchain date (though the incorrect target). Whereas cargo requires setting the full nightly-2023-09-30 in the action's toolchain field.

I'm happy to look into this myself, just wondering if anybody has any insights?

@tombh
Copy link
Author

tombh commented Oct 14, 2024

Looks like this is a known issue in cross: cross-rs/cross#1541

@autarch
Copy link
Member

autarch commented Oct 14, 2024

I'm going to close this since it's a cross issue. Hopefully they'll do a release some time soon.

@autarch autarch closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants