Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SwiftLint to 0.41.0 to Allow Inclusive Languages #1825

Open
shiki opened this issue Nov 19, 2020 · 2 comments
Open

Upgrade SwiftLint to 0.41.0 to Allow Inclusive Languages #1825

shiki opened this issue Nov 19, 2020 · 2 comments

Comments

@shiki
Copy link

shiki commented Nov 19, 2020

We're removing non-inclusive languages from our open source project. One of the remaining items is the whitelist_rules configuration we use for SwiftLint.

SwiftLint version 0.41.0 adds an inclusive version for this, only_rules (realm/SwiftLint#3243). At the time of this writing, Hound only supports 0.27.0.

We tried setting the version directly in .hound.yml:

swiftlint:
    config_file: .swiftlint.yml	    config_file: .swiftlint.yml
    version: 0.41.0

But, as expected, Hound responded with:

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported. 
See a list of supported versions on our docs page.

It'd be great if 0.41.0 for SwiftLint is supported. 🙂

@mrgrauel
Copy link

According to the supported linters you only support version 0.27.0 of SwiftLint.
Why do you only support such an old version? This version is over two and half years old. Please keep the version up to date. Your service is nice, but such an old version is no-go.

@joshheald
Copy link

I can see that the Supported Linters page now lists 0.43.1 for SwiftLint... however, we're still getting the following error when we add PRs with that version of SwiftLint configured:

Some files could not be reviewed due to errors:

The configured swiftlint version is not supported.

e.g. woocommerce/woocommerce-ios#6956

It would be really helpful if these newer versions could be supported, or if there's any clues you can suggest about things I could check with our setup, I'd be grateful and happy to help with the investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants