Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Github CI check to make sure that if an asset is edited, ui/bindata.go is updated #365

Open
salemhilal opened this issue Oct 30, 2020 · 0 comments
Labels
enhancement good first issue These issues are a great way to get to know Hound's codebase help wanted

Comments

@salemhilal
Copy link
Contributor

We serve static assets from a serialized file in order to make Hound go-get-able (see #7). Confirming that UI PRs come with an update to ui/bindata.go would be helpful for future PRs.

Here's some helpful context (thanks to @kellegous for a lot of this):

  1. ui/bindata.go contains all the contents from ui/assets/* and is generated here in the Makefile.
  2. Generating ui/bindata.go as part of the install (i.e. in //go:generate) might be finicky on some systems, so sticking with manually updating it is a safer play for now.
  3. As mentioned above, Issue Please make it go get-able #7 has more context for why we use this approach.
  4. If you're curious, assets are read in from ui/bindata.go through calls to Asset in ui#serveAsset.
@salemhilal salemhilal added enhancement help wanted good first issue These issues are a great way to get to know Hound's codebase labels Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue These issues are a great way to get to know Hound's codebase help wanted
Projects
None yet
Development

No branches or pull requests

1 participant