Skip to content

Commit

Permalink
Switch to js:test
Browse files Browse the repository at this point in the history
  • Loading branch information
wwahammy committed Aug 28, 2023
1 parent b2c957d commit ff04617
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ jobs:
- run: bin/setup ci
- name: Generate JS routes
run: bin/rails js:routes:typescript
- name: run jest
run: yarn jest
- name: run js:test
run: yarn js:test
webpack:
needs: package-download
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ failures is zero.
We also recommend you run through the javascript test cases by running:

```bash
yarn jest
yarn js:test
```

Lastly, you can use [Storybook](https://storybook.js.org/) to experiment with
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started_wsl2.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ The important thing to look for is that the number of failures is zero.
We also recommend you run through the JavaScript test cases by running:

```bash
yarn jest
yarn js:test
```

Lastly, you can use [Storybook](https://storybook.js.org/) to experiment with
Expand Down
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,16 @@
"scripts": {
"build-all": "yarn install --frozen-lockfile && script/compile-assets.sh && yarn build",
"ci-build-all": "script/compile-assets.sh && yarn build",
"test": "bin/rails spec && yarn jest",
"jest": "bin/rails js:generate && jest",
"jest_only": "jest",
"test": "bin/rails spec && yarn js:test",
"js:test": "bin/rails js:generate && jest",
"eslint": "eslint . --ext .ts,.js,.tsx",
"storybook": "bin/rails js:generate && start-storybook -p 6006 -c .storybook/react --no-version-updates --no-release-notes",
"build-storybook": "bin/rails js:generate && build-storybook -c .storybook/react",
"html-storybook": "bin/start-html-storybook -p 6007 -c .storybook/html --no-version-updates --no-release-notes",
"build-html-storybook": "bin/build-html-storybook -c .storybook/html",
"markdownlint": "npx markdownlint-cli '**/*.md' --ignore node_modules",
"prepare-for-push": "yarn test && yarn eslint --fix && yarn markdownlint --fix && bin/rails notice:update",
"prepare-for-push-js": "yarn jest && yarn eslint --fix && yarn markdownlint --fix && bin/rails notice:js:update",
"prepare-for-push-js": "yarn js:test && yarn eslint --fix && yarn markdownlint --fix && bin/rails notice:js:update",
"notice:js": "npx @houdiniproject/noticeme@^1.1.0-pre1 -f NOTICE-js -i included.json -s 250",
"webpack": "bin/webpack"
},
Expand Down
2 changes: 1 addition & 1 deletion script/test.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
yarn ci && bin/rails db:create db:schema:load db:migrate && RAILS_ENV=test bin/rails db:create db:schema:load test:prepare && bin/rails spec && yarn run build-all && yarn jest
yarn ci && bin/rails db:create db:schema:load db:migrate && RAILS_ENV=test bin/rails db:create db:schema:load test:prepare && bin/rails spec && yarn run build-all && yarn js:test

0 comments on commit ff04617

Please sign in to comment.