Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No history state pushed when adding turbo frames #130

Closed
gunnarmorling opened this issue Jan 23, 2021 · 4 comments
Closed

No history state pushed when adding turbo frames #130

gunnarmorling opened this issue Jan 23, 2021 · 4 comments

Comments

@gunnarmorling
Copy link

gunnarmorling commented Jan 23, 2021

When adding <turbo-frame id="shell">...</turbo-frame>, HTTP requests are issued via Turbo, but no state is changed to the browser history, i.e. the contents of the address bar doesn't change.

@seanpdoyle
Copy link
Contributor

Is this related to #50?

@gunnarmorling
Copy link
Author

Yes, perhaps it is. I was thinking #50 is different due to all the video-related things it mentions, but reading it again, this is exactly what I'm observing:

Use the new Turbo Frames feature (which works), but then the URL doesn't get updated

So is this a known limitation then? Using <turbo-frame> makes a huge difference for me with Firefox in terms of perceived performance (in fact, initially I thought Turbo isn't working at all when using it without <turbo-frame> in FF, as it didn't seem to make a difference), so it'd be very desirable to use. But the lack of history update makes it not really usable atm.

@seanpdoyle
Copy link
Contributor

So is this a known limitation then?

I believe this behavior is a design decision.

I'm closing this issue in favor of #50. If you have further thoughts, please share them there.

@gunnarmorling
Copy link
Author

gunnarmorling commented Jan 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants