Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier keys ignored for form submissions #1299

Open
mburtscher opened this issue Aug 21, 2024 · 0 comments
Open

Modifier keys ignored for form submissions #1299

mburtscher opened this issue Aug 21, 2024 · 0 comments

Comments

@mburtscher
Copy link

mburtscher commented Aug 21, 2024

For clicks on regular hyperlinks, Turbo does notice when a modifier key like CMD (new tab) or SHIFT (new window) is pressed and will skip Turbo navigation in favor of a native navigation action. This leads to a consistent behavior of Turbo powered apps.

However for form submissions, these modifier keys are ignored and Turbo navigation happens even if modifier keys are used.

An implementation like LinkClickObserver.clickEventIsSignificant must be added to the FormSubmitObserver as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant