-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixed osm download destroy issue #6375
feat: fixed osm download destroy issue #6375
Conversation
@ramyaragupathy we currently have issue on CircleCI because of the node version upgrade and need a change on the CIRCLECI config and i just consult with @mahesh-naxa and he suggested to do multiple changes on CircleCI config for upgrading the node version on CircleCI which he would be doing. so might have to wait for him to fix this |
Looks like there are two checks failing.
passing this down to @eternaltyro
will update those in a seperate PR ASAP. |
1f324ba
to
72db554
Compare
Quality Gate passedIssues Measures |
@ramyaragupathy @royallsilwallz @manjitapandey everything is passed except the two that DK had already mentioned will be failed anyways so it is good to go i guess. |
|
@ramyaragupathy I have updated circleci with the newer node versions, this one is specific to this PR, as this PR is generated from a fork by @varun2948.
Its an an auth issue where packages are not allowed to be pushed to github container registry from a forked repo. |
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR fixes the crash issue on osm download component which was caused due to the react,node upgrade
Screenshots
Issue:
After Fix :
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?