Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let users validate a square they worked on #909

Closed
aawiseman opened this issue Dec 5, 2016 · 6 comments
Closed

Don't let users validate a square they worked on #909

aawiseman opened this issue Dec 5, 2016 · 6 comments

Comments

@aawiseman
Copy link

Or something like that -- I've seen in a few cases were new editors mapped and area then marked it as validated and left behind bad data.

Or (more complicated) only let more experienced or approved people validate their own squares.

@pgiraud
Copy link
Collaborator

pgiraud commented Dec 5, 2016

This was addressed a while ago. #602
It looks like we're facing a regression somewhere.

@pgiraud
Copy link
Collaborator

pgiraud commented Dec 5, 2016

This should be checked server-side as well. Sorry for my poor review on this pull request.

@smit1678
Copy link

smit1678 commented Dec 5, 2016

I saw this working correctly on Friday at our workshop. New user tried to validate their own square but could not. @aawiseman did you happen to see this recently or replicate this?

@pgiraud
Copy link
Collaborator

pgiraud commented Dec 5, 2016

@aawiseman FYI administrators or project managers can validate the tasks they worked on. Simple contributors don't.

@aawiseman
Copy link
Author

Oh, my bad, I last saw it on the TeachOSM tasking manager. I do remember seeing it here though, but maybe that was before the code change? http://tasks.hotosm.org/project/1080

@bgirardot
Copy link
Contributor

I think this is fixed. I will test and reopen if needed..

Thank you @aawiseman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants