Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search data file #315

Closed
pyrog opened this issue Feb 1, 2015 · 3 comments
Closed

Improve search data file #315

pyrog opened this issue Feb 1, 2015 · 3 comments

Comments

@pyrog
Copy link

pyrog commented Feb 1, 2015

  1. The files generated by jekyll contain a lot of spaces and empty lines, especially all-translation.json used by the jQuery search script.
    It could be minified with a Jekyll plugin or ruby script run by travis/rake.
  2. Also, this file contain titles in all languages but the search script use only the current language.
    So, we could generate a file by language and load only one at a time.
  3. Search take care of accentuated char:
    • In french the search editeur return "Edition avancée", "Editer le Wiki OSM"
    • The search éditeur find "Éditer à distance…", "Éditeur iD", "Éditer avec JOSM"

💡 To "fix" this, I suggest to test a plugin with full text search capabilities like jekyll-lunr-js-search

@althio
Copy link
Collaborator

althio commented Feb 19, 2015

Originates from #19 (comment)
Discussed in #150

Need to assess the proposal from @pyrog with

💡 To "fix" this, I suggest to test a plugin with full text search capabilities like jekyll-lunr-js-search

@pyrog
Copy link
Author

pyrog commented Feb 22, 2015

See #328 to discuss how to use Travis.CI

@Nick-Tallguy
Copy link
Collaborator

Closing as stale. A champion willing to work on this is weL come to open it and work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants