Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Kakarot support #152
feat: add Kakarot support #152
Changes from 8 commits
bbcf30d
1cdce49
04d2898
3533c90
a8d2fdb
5f1c432
c81a807
2dbdcd5
1bb12aa
3d85dce
c15c718
78434de
6cc0654
29ac451
6c8e8bf
ceb9f6b
cf9f0a2
4416bc9
25f5ff1
0548bc3
1e77ac4
62602d3
5866470
3c111a0
834a033
83e7279
fc6954b
0ae499d
9886896
f0adb00
3811bf0
f13375a
66545f4
f3f11c6
c50a44e
cb5aa17
a793172
0208cbd
d2c6dc5
c8c262d
b508ebe
f672a28
a50c9ea
4e7d295
e827426
066cc7b
bd078e9
5cdd0cc
13cc5dc
17c14d6
04e9077
b22d866
8cc5d0d
ff6125b
44361bd
dd30f6d
30a9de1
4f1c6fa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the negation. you meant:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a command to initialize git too within the
initialize-kakarot
. ie&& git init
.Not doing this, makes the next command
setup-kakarot
fail with error: not a git repositoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script fails with:
please look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this script fails too and the one after it.