feat: add Kakarot support #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EjembiEmmanuel is attempting to deploy a commit to the Horus Labs Team on Vercel. A member of the Team first needs to authorize it. |
Darlington02
requested changes
Sep 27, 2024
bin/cli.mjs
Outdated
| await exec( | ||
| "npm run install --legacy-peer-deps && npm run initialize-dojo" | ||
| ); | ||
| } else if (packageType !== "kakarot") { |
There was a problem hiding this comment.
remove the negation. you meant:
else if (packageType == "kakarot")
package.json
Outdated
| @@ -22,7 +22,12 @@ | |||
| "devnet": "sh ./devnet/start.sh", | |||
| "start": "cd frontend && npm run dev", | |||
| "install": "cd scripts && bash install_tools.sh && cd ../frontend && npm install --legacy-peer-deps", | |||
| "build-ui": "cd frontend && npm run build" | |||
| "build-ui": "cd frontend && npm run build", | |||
| "initialize-kakarot": "rm -rf contracts && mkdir contracts && cd contracts && git clone https://github.com/kkrt-labs/build-on-kakarot.git && cp -r build-on-kakarot/* ./ && rm -rf .github && rm -rf .trunk && rm -rf build-on-kakarot", | |||
There was a problem hiding this comment.
include a command to initialize git too within the initialize-kakarot. ie && git init.
Not doing this, makes the next command setup-kakarot fail with error: not a git repository
package.json
Outdated
| "build-ui": "cd frontend && npm run build", | ||
| "initialize-kakarot": "rm -rf contracts && mkdir contracts && cd contracts && git clone https://github.com/kkrt-labs/build-on-kakarot.git && cp -r build-on-kakarot/* ./ && rm -rf .github && rm -rf .trunk && rm -rf build-on-kakarot", | ||
| "setup-kakarot": "cd contracts && make setup", | ||
| "start-kakarot": "cd contracts && make start", |
There was a problem hiding this comment.
script fails with:
make -C lib/kakarot-rpc local-rpc-up
make[1]: *** No rule to make target `local-rpc-up'. Stop.
make: *** [start] Error 2
please look into it.
package.json
Outdated
| "initialize-kakarot": "rm -rf contracts && mkdir contracts && cd contracts && git clone https://github.com/kkrt-labs/build-on-kakarot.git && cp -r build-on-kakarot/* ./ && rm -rf .github && rm -rf .trunk && rm -rf build-on-kakarot", | ||
| "setup-kakarot": "cd contracts && make setup", | ||
| "start-kakarot": "cd contracts && make start", | ||
| "deploy-kakarot-l1-messaging-contracts": "cd contracts && make deploy-l1", |
There was a problem hiding this comment.
this script fails too and the one after it.
This reverts commit dd30f6d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Kakarot zkEVM on Starknet-Scaffold
Additional Information