fix: replace map + mutex with sync.Map #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiloson <[email protected]>
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -136,7 +108,7 @@ func NewRegionInformers(regionMgr manager.Manager, defaultResync time.Duration) | |||
| return &f | |||
| } | |||
|
|
|||
| func (f *RegionInformers) NewRegionInformers(region *models.Region) error { | |||
| func (f *RegionInformers) NewRegionInformer(region *models.Region) error { | |||
There was a problem hiding this comment.
Method RegionInformers.NewRegionInformer has 7 return statements (exceeds 4 allowed).
|
Code Climate has analyzed commit baf6c7e and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 66.4%. View more on Code Climate. |
|
This issue is stale because it has been open 30 days with no activity. |
|
This PR was closed because it has been stalled for 5 days with no activity. You can reopen it if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make build && make lintto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer