Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish Cargo.lock with the crate #3

Closed
polyzen opened this issue Nov 5, 2018 · 7 comments
Closed

Please publish Cargo.lock with the crate #3

polyzen opened this issue Nov 5, 2018 · 7 comments

Comments

@polyzen
Copy link

polyzen commented Nov 5, 2018

    Updating crates.io index
    Updating git repository `https://github.com/hoodie/notify-rust/`
error: the lock file needs to be updated but --locked was passed to prevent this
@polyzen polyzen changed the title Please update the lock file Please consider using Cargo.lock Nov 5, 2018
@polyzen polyzen changed the title Please consider using Cargo.lock Please consider committing Cargo.lock Nov 5, 2018
@hoodie
Copy link
Owner

hoodie commented Nov 6, 2018

sure thing, how about now?

@polyzen
Copy link
Author

polyzen commented Nov 6, 2018

Thank you very much. :)

I see this is now also available as a crate. Could you try this to publish the lock file with the crate?:
rust-lang/cargo#5654

@polyzen polyzen closed this as completed Nov 7, 2018
@hoodie
Copy link
Owner

hoodie commented Nov 7, 2018

That's not the default? I thought it published all checked in files automatically, I'll look

@hoodie hoodie reopened this Nov 7, 2018
@polyzen
Copy link
Author

polyzen commented Nov 7, 2018

@polyzen polyzen changed the title Please consider committing Cargo.lock Please publish Cargo.lock with the crate Nov 7, 2018
@polyzen
Copy link
Author

polyzen commented Nov 15, 2018

I've learned unstable Cargo features require Cargo nightly. Will bump this once it's stabilized.

@hoodie
Copy link
Owner

hoodie commented Jun 3, 2019

@polyzen ping

@polyzen polyzen closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants