4.4.7 broke array types in Context

[dustinsmith1024]

What version of Hono are you using?

4.4.7+

What runtime/platform is your app running on?

Cloudflare Workers

What steps can reproduce the bug?

I am attempting to upgrade to the latest 4.4 versions and I get a types issue with Array based elements in the HonoContext.

Sample context:

export interface DC {
  name: string;
  url: string;
}

declare module 'hono' {
  interface ContextVariableMap {
    jwt: JWTInterface;
    dcs: DC[];
    allowAllOrigins: boolean;
    allowedOrigins: string[];
    appToken: string;
    appEnv: string;
  }
}

What is the expected behavior?

No type errors should happen. This doesn't happen on 4.4.6, so maybe related to #2987?

What do you see instead?

➜ pnpm run -F gateway-router tsc

> [email protected] tsc router
> tsc --noEmit                                 ~~

src/file.ts:327:16 - error TS7006: Parameter 'dc' implicitly has an 'any' type.

327       .filter((dc) => userDcs.includes(dc.name))
                   ~~

src/file.ts:328:13 - error TS7006: Parameter 'dc' implicitly has an 'any' type.

328       .map((dc) => {
                ~~

src/file.ts:50:40 - error TS7006: Parameter 'dc' implicitly has an 'any' type.

50     if (!body.dc || c.get('dcs').find((dc) => dc.name === body.dc) === undefined) {
                                          ~~

src/file2.ts:180:55 - error TS7006: Parameter 'allowed' implicitly has an 'any' type.

180         const allowed = c.get('allowedOrigins').find((allowed) => origin === allowed);
                                                          ~~~~~~~

Additional information

No response

[yusukebe]

Hi @dustinsmith1024

Is this way of reproducing it correctly?

Area.mp4

If so, it does not throw errors. Can you provide a minimal project to reproduce it?

[dustinsmith1024]

Here you go: https://github.com/dustinsmith1024/hono-types-issue

[yusukebe]

@dustinsmith1024 Thanks. Will be fixed soon.

[dustinsmith1024]

Awesome thanks - Should I be doing something different with Context to prevent it?

[yusukebe]

@dustinsmith1024

Should I be doing something different with Context to prevent it?

It's a bug, so you don't have to add anything. Just wait for a new version!

[yusukebe]

Hi @dustinsmith1024

This may be fixed in the latest version v4.5.0. Can you try it?

[yusukebe]

We can close this issue now. If you still have a problem, feel free to reopen.