From 7446279f572b8c49d6c34a1d6f8def427cc77f8b Mon Sep 17 00:00:00 2001 From: Joram van den Boezem Date: Thu, 8 Dec 2022 15:57:44 +0000 Subject: [PATCH 1/3] chore: attempt dry-run --- .github/workflows/ci.yml | 3 ++- README.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 22198dfb..81dc38e5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,8 @@ jobs: - run: yarn install - run: yarn build - run: yarn test - - run: yarn release --dry-run + - run: | + yarn release --dry-run --no-ci --branches main,${{ env.GITHUB_HEAD_REF }} env: GH_TOKEN: ${{ secrets.GH_PAT }} YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/README.md b/README.md index 8c5db7e9..5ee66609 100644 --- a/README.md +++ b/README.md @@ -240,7 +240,7 @@ yarn husky install - [ ] Monorepo support - [x] Support for fixed versions - [x] Support for private/non-private root package - - [ ] Support for channels (added failing tests) + - [x] Support for channels - [ ] Support for release information for each workspace - [ ] Support for independant versions (probably impossible without custom analyze-commits plugin) From da6411fc73ce0bfb0da41ca67586cf82a23fbbcb Mon Sep 17 00:00:00 2001 From: Joram van den Boezem Date: Thu, 8 Dec 2022 16:01:22 +0000 Subject: [PATCH 2/3] fix: verify-config --- src/verify-config.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/verify-config.ts b/src/verify-config.ts index 75e62211..bd2e94bc 100644 --- a/src/verify-config.ts +++ b/src/verify-config.ts @@ -18,6 +18,10 @@ export function verifyConfig(config: PluginConfig) { return errors; } + if (!(option in VALIDATORS)) { + return errors; + } + if (VALIDATORS[option as keyof PluginConfig](value)) { return errors; } From 460b0aa494956026c2753db60c8d94c61dc4beb1 Mon Sep 17 00:00:00 2001 From: Joram van den Boezem Date: Thu, 8 Dec 2022 16:08:05 +0000 Subject: [PATCH 3/3] chore: disable release dry run in ci --- .github/workflows/ci.yml | 16 +++++++++++----- .github/workflows/release.yml | 3 +-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 81dc38e5..99fa4622 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,8 +30,14 @@ jobs: - run: yarn install - run: yarn build - run: yarn test - - run: | - yarn release --dry-run --no-ci --branches main,${{ env.GITHUB_HEAD_REF }} - env: - GH_TOKEN: ${{ secrets.GH_PAT }} - YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + # Disabled due to error: + # ``` + # ✖ EINVALIDBRANCH A branch is invalid in the `branches` configuration. + # Each branch in the branches configuration (https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches) must be either a string, a regexp or an object with a name property. + # Your configuration for the problematic branch is ``. + # ``` + # - run: | + # yarn release --debug --dry-run --no-ci --branches main,${{ env.GITHUB_HEAD_REF }} + # env: + # GH_TOKEN: ${{ secrets.GH_PAT }} + # YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6e298f1b..2cc0c1b3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,8 +19,7 @@ jobs: cache: yarn - run: yarn install - run: yarn build - - run: yarn release + - run: yarn release --debug env: - DEBUG: semantic-release:* GITHUB_TOKEN: ${{ secrets.GH_PAT }} YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}