Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: log spam with GOAWAY errors; txmit not retried on GOAWAY #158

Closed
lizthegrey opened this issue Jan 4, 2022 · 2 comments
Closed

bug: log spam with GOAWAY errors; txmit not retried on GOAWAY #158

lizthegrey opened this issue Jan 4, 2022 · 2 comments

Comments

@lizthegrey
Copy link
Member

error sending libhoney event: Post \"https://api-kibble.honeycomb.io/1/batch/retriever-traces\": http2: Transport: cannot retry err [http2: Transport received Server's graceful shutdown GOAWAY] after Request.Body was written; define Request.GetBody to avoid this error

this is related to the work I did to fix content-length; GetBody is defined if you pass in a raw bytes.Buffer but not if you pass a subclass or embed of bytes.Buffer. #156 (comment)

@lizthegrey lizthegrey changed the title bug: log spam with GOAWAY errors bug: log spam with GOAWAY errors; txmit not retried on GOAWAY Jan 4, 2022
@lizthegrey
Copy link
Member Author

More specifically on this bug: while it prints a warning, we do have our external retry, but GOAWAY should be retried internally to http rather than needing us to externally retry. So it's better to support handling this directly by passing the bytes.Buffer directly into http.Request

@MikeGoldsmith
Copy link
Contributor

Closed by #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants